📚 Tutorial: chore: Enable clang-tidy misc checks by godexsoft · Pull Request #6655 · XRPLF/rippled · GitHub

godexsoft · 2026-03-25T19:44:08Z

High Level Overview of Change

This PR enables various checks:

llvm-namespace-comment
misc-const-correctness
misc-definitions-in-headers
misc-throw-by-value-catch-by-reference
misc-redundant-expression

API Impact

No impact.

github-actions · 2026-03-27T04:31:27Z

This PR has conflicts, please resolve them in order for the PR to be reviewed.

github-actions · 2026-03-30T18:02:31Z

All conflicts have been resolved. Assigned reviewers can now start or resume their review.

godexsoft · 2026-03-31T01:06:28Z

        continue-on-error: true
        env:
-          TARGETS: ${{ inputs.files != '' && inputs.files || 'src tests' }}
+          TARGETS: ${{ inputs.files != '' && inputs.files || '^(?!.*src/tests/libxrpl/protocol_autogen/).*(/src/|/tests/).*\.cpp$' }}


So this is the easiest way for now, we don't want to run tidy on generated code, eventually we may want to enable it but i think it's best left for last moment when all other code is fully compliant.

Shouldn't we exclude generated code paths in .clang-tidy file instead?

I'm not aware of such option in clang-tidy. The closest thing i know of is header filter and exclude filter but that only affects #included code, not inputs directly consumed by clang-tidy

@mathbunnyru to the rescue here.

I think I found a way - put a second .clang-tidy file in the directory you want to exclude with

# This disables all checks for this directory and its subdirectories Checks: '-*' InheritParentConfig: false

Source: https://stackoverflow.com/a/75586089

Oh! this is actually a great idea, i will try, thanks for the suggestion

@bthomee I rescued 😂

codecov · 2026-03-31T01:22:14Z

Codecov Report

❌ Patch coverage is 86.78501% with 67 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.4%. Comparing base (7f53351) to head (459be62).
⚠️ Report is 2 commits behind head on develop.

Files with missing lines	Patch %	Lines
include/xrpl/resource/detail/Logic.h	55.6%	8 Missing ⚠️
src/libxrpl/nodestore/backend/RocksDBFactory.cpp	41.7%	7 Missing ⚠️
src/libxrpl/json/json_reader.cpp	68.4%	6 Missing ⚠️
src/libxrpl/nodestore/DatabaseRotatingImp.cpp	55.6%	4 Missing ⚠️
src/libxrpl/rdb/SociDB.cpp	20.0%	4 Missing ⚠️
src/libxrpl/basics/Log.cpp	57.1%	3 Missing ⚠️
src/libxrpl/beast/insight/StatsDCollector.cpp	0.0%	3 Missing ⚠️
src/libxrpl/core/detail/JobQueue.cpp	83.3%	3 Missing ⚠️
src/libxrpl/shamap/SHAMapSync.cpp	66.7%	3 Missing ⚠️
src/libxrpl/basics/Archive.cpp	0.0%	2 Missing ⚠️
... and 20 more

Additional details and impacted files

@@            Coverage Diff            @@
##           develop   #6655     +/-   ##
=========================================
- Coverage     81.5%   81.4%   -0.1%     
=========================================
  Files          999     999             
  Lines        74459   74458      -1     
  Branches      7563    7577     +14     
=========================================
- Hits         60652   60613     -39     
- Misses       13807   13845     +38

Files with missing lines	Coverage Δ
include/xrpl/basics/BasicConfig.h	`89.7% <100.0%> (ø)`
include/xrpl/basics/IntrusiveRefCounts.h	`92.7% <100.0%> (ø)`
include/xrpl/basics/SlabAllocator.h	`93.3% <100.0%> (ø)`
include/xrpl/basics/StringUtilities.h	`100.0% <100.0%> (ø)`
include/xrpl/basics/base_uint.h	`94.3% <100.0%> (ø)`
include/xrpl/basics/hardened_hash.h	`100.0% <100.0%> (ø)`
include/xrpl/basics/random.h	`100.0% <100.0%> (ø)`
include/xrpl/beast/asio/io_latency_probe.h	`96.5% <100.0%> (ø)`
include/xrpl/beast/utility/Zero.h	`100.0% <ø> (ø)`
include/xrpl/core/ClosureCounter.h	`100.0% <100.0%> (ø)`
... and 146 more

... and 16 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

godexsoft · 2026-03-31T01:27:01Z

@@ -23,7 +23,7 @@ operator==(Config const& lhs, Config const& rhs)
    return lhs.autoConnect == rhs.autoConnect && lhs.peerPrivate == rhs.peerPrivate &&
        lhs.wantIncoming == rhs.wantIncoming && lhs.inPeers == rhs.inPeers &&
        lhs.maxPeers == rhs.maxPeers && lhs.outPeers == rhs.outPeers &&
-        lhs.features == lhs.features && lhs.ipLimit == rhs.ipLimit &&


Looks like a copypasta bug caught 👍

Copilot

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

mathbunnyru

I checked random places, overall LGTM

bthomee · 2026-03-31T16:18:02Z

@godexsoft looks like more clang-tidy fixes are needed.

Enable llvm-namespace-comment

f5d3051

godexsoft added the DraftRunCI Normally CI does not run on draft PRs. This opts in. label Mar 25, 2026

godexsoft added 6 commits March 26, 2026 22:41

Add const-correctness and fix issues

4162fb8

Fix duplicate consts

974a6a7

Try to fix strange const duplication

66bc5ff

Fix a bunch of consts

d9371bd

Testing

5d6bae3

Fix more

029b22d

github-actions Bot added the PR: has conflicts label Mar 27, 2026

godexsoft requested review from kuznetsss and removed request for kuznetsss March 27, 2026 04:34

godexsoft added 4 commits March 30, 2026 17:48

Merge branch 'develop' into chore/clang-tidy-checks-misc

3b89fae

Autofixes after merge conflict resolution

dc13475

Fix one more thingy

88efd79

Merge branch 'develop' into chore/clang-tidy-checks-misc

f67205a

github-actions Bot removed the PR: has conflicts label Mar 30, 2026

godexsoft added 6 commits March 30, 2026 21:03

Add one more check and fix CI findings

4381818

One more

4ffc18f

Fix remaining issues from checks

a979b44

Fix CI-only things

9060eab

Revert to autogen

ed9ca5a

Update run-clang-tidy command to actually exclude autogen stuff

4f18e71

godexsoft commented Mar 31, 2026

View reviewed changes

godexsoft marked this pull request as ready for review March 31, 2026 01:27

godexsoft removed the DraftRunCI Normally CI does not run on draft PRs. This opts in. label Mar 31, 2026

bthomee self-requested a review March 31, 2026 09:58

kuznetsss requested a review from Copilot March 31, 2026 12:57

Copilot AI reviewed Mar 31, 2026

kuznetsss approved these changes Mar 31, 2026

View reviewed changes

bthomee approved these changes Mar 31, 2026

View reviewed changes

godexsoft added the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label Mar 31, 2026

bthomee added this pull request to the merge queue Mar 31, 2026

bthomee removed this pull request from the merge queue due to a manual request Mar 31, 2026

Different way to ignore autogenerated files

094938e

godexsoft requested a review from mathbunnyru March 31, 2026 15:02

mathbunnyru approved these changes Mar 31, 2026

View reviewed changes

bthomee added this pull request to the merge queue Mar 31, 2026

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Mar 31, 2026

godexsoft added 2 commits March 31, 2026 17:48

Merge branch 'develop' into chore/clang-tidy-checks-misc

fb0a22c

Add const to newly introduced lock

459be62

bthomee enabled auto-merge March 31, 2026 17:14

bthomee added this pull request to the merge queue Mar 31, 2026

Merged via the queue into XRPLF:develop with commit 2502bef Mar 31, 2026
3 checks passed

bthomee pushed a commit that referenced this pull request Apr 1, 2026

chore: Enable clang-tidy misc checks (#6655)

2dc705b

mvadari added this to the 3.2.0 milestone May 20, 2026

beartec-jpg pushed a commit to beartec-jpg/FalconLedger that referenced this pull request Jun 1, 2026

chore: Enable clang-tidy misc checks (XRPLF#6655)

2694128

Uh oh!

Conversation

godexsoft commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

High Level Overview of Change

API Impact

Uh oh!

github-actions Bot commented Mar 27, 2026

Uh oh!

github-actions Bot commented Mar 30, 2026

Uh oh!

godexsoft Mar 31, 2026

Choose a reason for hiding this comment

Uh oh!

kuznetsss Mar 31, 2026

Choose a reason for hiding this comment

Uh oh!

godexsoft Mar 31, 2026

Choose a reason for hiding this comment

Uh oh!

bthomee Mar 31, 2026

Choose a reason for hiding this comment

Uh oh!

mathbunnyru Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

godexsoft Mar 31, 2026

Choose a reason for hiding this comment

Uh oh!

mathbunnyru Mar 31, 2026

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

godexsoft Mar 31, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mathbunnyru left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bthomee commented Mar 31, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

godexsoft commented Mar 25, 2026 •

edited

Loading

mathbunnyru Mar 31, 2026 •

edited

Loading

codecov Bot commented Mar 31, 2026 •

edited

Loading