Sponsored Content
Skip to content

chore: Remove the forward declarations that cause build errors when unity build is enabled - #6633

Merged
bthomee merged 2 commits into
developfrom
a1q123456/remove-duplicate-declaration-of-dirlink
Mar 24, 2026
Merged

chore: Remove the forward declarations that cause build errors when unity build is enabled#6633
bthomee merged 2 commits into
developfrom
a1q123456/remove-duplicate-declaration-of-dirlink

Conversation

@a1q123456

@a1q123456 a1q123456 commented Mar 24, 2026

Copy link
Copy Markdown
Contributor

High Level Overview of Change

This PR removes the forward declarations from src/libxrpl/ledger/helpers/MPTokenHelpers.cpp because they cause build errors when unity build is on.

Context of Change

The forward declarations are not necessary and they cause build errors when unity build is on.

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

…ild is enabled

Signed-off-by: JCW <a1q123456@users.noreply.github.com>
@a1q123456
a1q123456 requested review from bthomee and mvadari March 24, 2026 17:34
@a1q123456 a1q123456 changed the title Remove the forward declarations that cause build errors when unity build is enabled chore: Remove the forward declarations that cause build errors when unity build is enabled Mar 24, 2026
@a1q123456 a1q123456 added the Trivial Simple change with minimal effect, or already tested. Only needs one approval. label Mar 24, 2026
@a1q123456 a1q123456 added the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label Mar 24, 2026
@bthomee
bthomee enabled auto-merge March 24, 2026 17:40
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
@codecov

codecov Bot commented Mar 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.5%. Comparing base (0eedefb) to head (3ff5672).
⚠️ Report is 4 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #6633   +/-   ##
=======================================
  Coverage     81.4%   81.5%           
=======================================
  Files          997     997           
  Lines        74410   74410           
  Branches      7562    7554    -8     
=======================================
+ Hits         60598   60612   +14     
+ Misses       13812   13798   -14     
Files with missing lines Coverage Δ
src/libxrpl/ledger/helpers/MPTokenHelpers.cpp 96.2% <100.0%> (ø)

... and 5 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bthomee
bthomee added this pull request to the merge queue Mar 24, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Mar 24, 2026
@bthomee
bthomee added this pull request to the merge queue Mar 24, 2026
Merged via the queue into develop with commit 4096623 Mar 24, 2026
3 checks passed
@bthomee
bthomee deleted the a1q123456/remove-duplicate-declaration-of-dirlink branch March 24, 2026 23:25
@mvadari mvadari added this to the 3.2.0 milestone May 20, 2026
beartec-jpg pushed a commit to beartec-jpg/FalconLedger that referenced this pull request Jun 1, 2026
…nity build is enabled (XRPLF#6633)

Signed-off-by: JCW <a1q123456@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. Trivial Simple change with minimal effect, or already tested. Only needs one approval.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants