chore: Remove the forward declarations that cause build errors when unity build is enabled - #6633
Merged
bthomee merged 2 commits intoMar 24, 2026
Conversation
…ild is enabled Signed-off-by: JCW <a1q123456@users.noreply.github.com>
mvadari
approved these changes
Mar 24, 2026
bthomee
approved these changes
Mar 24, 2026
bthomee
enabled auto-merge
March 24, 2026 17:40
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #6633 +/- ##
=======================================
Coverage 81.4% 81.5%
=======================================
Files 997 997
Lines 74410 74410
Branches 7562 7554 -8
=======================================
+ Hits 60598 60612 +14
+ Misses 13812 13798 -14
🚀 New features to boost your workflow:
|
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Mar 24, 2026
beartec-jpg
pushed a commit
to beartec-jpg/FalconLedger
that referenced
this pull request
Jun 1, 2026
…nity build is enabled (XRPLF#6633) Signed-off-by: JCW <a1q123456@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This PR removes the forward declarations from
src/libxrpl/ledger/helpers/MPTokenHelpers.cppbecause they cause build errors when unity build is on.Context of Change
The forward declarations are not necessary and they cause build errors when unity build is on.
API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)