🎯 Practical: refactor: Reorganize RPC handler files by mvadari · Pull Request #6628 · XRPLF/rippled · GitHub

mvadari · 2026-03-24T04:55:36Z

High Level Overview of Change

This PR:

Ensures that each RPC has its own handler .cpp file, to make them easier to find
Splits up the RPCs into subfolders, using https://xrpl.org/docs/references/http-websocket-apis/public-api-methods and https://xrpl.org/docs/references/http-websocket-apis/admin-api-methods for reference on how to divide them up

There is no functionality or source code change, only moving code around and renaming files/headers.

Context of Change

Making the repo easier to manage/traverse

API Impact

N/A

codecov · 2026-03-24T05:35:22Z

Codecov Report

❌ Patch coverage is 75.17241% with 36 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.4%. Comparing base (6b55c4c) to head (f1b9841).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines	Patch %	Lines
...ld/rpc/handlers/admin/peer/PeerReservationsDel.cpp	0.0%	15 Missing ⚠️
...d/rpc/handlers/admin/peer/PeerReservationsList.cpp	0.0%	7 Missing ⚠️
src/xrpld/rpc/handlers/ChannelVerify.cpp	83.9%	5 Missing ⚠️
src/xrpld/rpc/handlers/account/AccountNFTs.cpp	93.0%	5 Missing ⚠️
src/xrpld/rpc/handlers/orderbook/NFTBuyOffers.cpp	71.4%	2 Missing ⚠️
src/xrpld/rpc/handlers/orderbook/NFTSellOffers.cpp	71.4%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##           develop   #6628     +/-   ##
=========================================
- Coverage     81.4%   81.4%   -0.0%     
=========================================
  Files          999    1006      +7     
  Lines        74440   74440             
  Branches      7560    7560             
=========================================
- Hits         60625   60613     -12     
- Misses       13815   13827     +12

Files with missing lines	Coverage Δ
src/xrpld/overlay/detail/OverlayImpl.cpp	`32.8% <ø> (ø)`
src/xrpld/rpc/detail/Handler.cpp	`88.1% <ø> (ø)`
src/xrpld/rpc/handlers/account/AccountChannels.cpp	`81.4% <ø> (ø)`
...c/xrpld/rpc/handlers/account/AccountCurrencies.cpp	`97.5% <ø> (ø)`
src/xrpld/rpc/handlers/account/AccountInfo.cpp	`85.4% <ø> (ø)`
src/xrpld/rpc/handlers/account/AccountLines.cpp	`91.2% <ø> (ø)`
src/xrpld/rpc/handlers/account/AccountObjects.cpp	`95.6% <ø> (ø)`
src/xrpld/rpc/handlers/account/AccountOffers.cpp	`89.5% <ø> (ø)`
src/xrpld/rpc/handlers/account/AccountTx.cpp	`86.5% <100.0%> (ø)`
src/xrpld/rpc/handlers/account/GatewayBalances.cpp	`89.4% <ø> (ø)`
... and 66 more

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Tapanito · 2026-03-24T15:17:56Z

/ai-review

xrplf-ai-reviewer

Ship it

Review by Claude Opus 4.6 · Prompt: V12

Tapanito · 2026-03-24T17:08:27Z

Nice, clean reorganisation. LGTM.

github-actions · 2026-03-26T00:44:31Z

This PR has conflicts, please resolve them in order for the PR to be reviewed.

github-actions · 2026-04-02T22:40:04Z

All conflicts have been resolved. Assigned reviewers can now start or resume their review.

Copilot

Pull request overview

This PR reorganizes the JSON-RPC handler implementation files into a clearer folder structure (by RPC category) and splits several handlers so each RPC has its own dedicated .cpp file, improving discoverability and navigation.

Changes:

Moved/split RPC handlers into category subfolders (e.g., account/, ledger/, orderbook/, server_info/, transaction/, utility/, admin/...).
Extracted shared helper logic into dedicated headers (e.g., NFTOffersHelpers.h, LedgerEntryHelpers.h, GetCounts.h) and adjusted include paths accordingly.
Renamed the internal handler function for account_tx from doAccountTxJson to doAccountTx and updated handler registration.

Reviewed changes

Copilot reviewed 21 out of 82 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
src/xrpld/rpc/handlers/utility/Random.cpp	New standalone handler file for `random`.
src/xrpld/rpc/handlers/utility/Ping.cpp	New standalone handler file for `ping`.
src/xrpld/rpc/handlers/transaction/TxReduceRelay.cpp	New standalone handler file for `tx_reduce_relay`.
src/xrpld/rpc/handlers/transaction/TxHistory.cpp	New standalone handler file for `tx_history`.
src/xrpld/rpc/handlers/transaction/Tx.cpp	New standalone handler file for `tx`.
src/xrpld/rpc/handlers/transaction/TransactionEntry.cpp	New standalone handler file for `transaction_entry`.
src/xrpld/rpc/handlers/transaction/SubmitMultiSigned.cpp	New standalone handler file for `submit_multisigned`.
src/xrpld/rpc/handlers/transaction/Submit.cpp	New standalone handler file for `submit`.
src/xrpld/rpc/handlers/transaction/Simulate.cpp	New standalone handler file for `simulate`.
src/xrpld/rpc/handlers/subscribe/Unsubscribe.cpp	Moved/split `unsubscribe` into its own file under `subscribe/`.
src/xrpld/rpc/handlers/subscribe/Subscribe.cpp	Moved/split `subscribe` into its own file under `subscribe/`.
src/xrpld/rpc/handlers/server_info/Version.h	Moved `version` handler into `server_info/` as a class-based handler.
src/xrpld/rpc/handlers/server_info/ServerState.cpp	New standalone handler file for `server_state`.
src/xrpld/rpc/handlers/server_info/ServerInfo.cpp	New standalone handler file for `server_info`.
src/xrpld/rpc/handlers/server_info/ServerDefinitions.cpp	New standalone handler file for `server_definitions`.
src/xrpld/rpc/handlers/server_info/Manifest.cpp	New standalone handler file for `manifest`.
src/xrpld/rpc/handlers/server_info/Fee.cpp	New standalone handler file for `fee`.
src/xrpld/rpc/handlers/server_info/Feature.cpp	New standalone handler file for `feature`.
src/xrpld/rpc/handlers/orderbook/RipplePathFind.cpp	Moved `ripple_path_find` under `orderbook/`.
src/xrpld/rpc/handlers/orderbook/PathFind.cpp	Moved `path_find` under `orderbook/`.
src/xrpld/rpc/handlers/orderbook/NFTSellOffers.cpp	Split `nft_sell_offers` into its own `.cpp`.
src/xrpld/rpc/handlers/orderbook/NFTOffersHelpers.h	Extracted shared NFT offer enumeration helpers into a header.
src/xrpld/rpc/handlers/orderbook/NFTBuyOffers.cpp	Split `nft_buy_offers` into its own `.cpp`.
src/xrpld/rpc/handlers/orderbook/GetAggregatePrice.cpp	Moved `get_aggregate_price` under `orderbook/`.
src/xrpld/rpc/handlers/orderbook/DepositAuthorized.cpp	Moved `deposit_authorized` under `orderbook/`.
src/xrpld/rpc/handlers/orderbook/BookOffers.cpp	Removed embedded `book_changes` handler implementation.
src/xrpld/rpc/handlers/orderbook/BookChanges.cpp	New standalone handler file for `book_changes`.
src/xrpld/rpc/handlers/orderbook/AMMInfo.cpp	Moved `amm_info` under `orderbook/`.
src/xrpld/rpc/handlers/ledger/LedgerHeader.cpp	New standalone handler file for `ledger_header`.
src/xrpld/rpc/handlers/ledger/LedgerEntryHelpers.h	Introduced helper header for `ledger_entry` parsing/validation.
src/xrpld/rpc/handlers/ledger/LedgerEntry.cpp	Updated include path for moved `LedgerEntryHelpers.h`.
src/xrpld/rpc/handlers/ledger/LedgerDiff.cpp	New standalone gRPC handler file for ledger diff.
src/xrpld/rpc/handlers/ledger/LedgerData.cpp	New standalone handler file for `ledger_data` (+ gRPC).
src/xrpld/rpc/handlers/ledger/LedgerCurrent.cpp	New standalone handler file for `ledger_current`.
src/xrpld/rpc/handlers/ledger/LedgerClosed.cpp	New standalone handler file for `ledger_closed`.
src/xrpld/rpc/handlers/ledger/Ledger.h	Moved/renamed `ledger` class-based handler header into `ledger/`.
src/xrpld/rpc/handlers/ledger/Ledger.cpp	Updated include to new `ledger/Ledger.h` location.
src/xrpld/rpc/handlers/Handlers.h	Updated handler declarations / includes (incl. `ledger/Ledger.h`, `doAccountTx`).
src/xrpld/rpc/handlers/ChannelVerify.cpp	Split `channel_verify` into its own handler file.
src/xrpld/rpc/handlers/admin/UnlList.cpp	Moved `unl_list` under `admin/`.
src/xrpld/rpc/handlers/admin/status/Validators.cpp	Moved `validators` under `admin/status/`.
src/xrpld/rpc/handlers/admin/status/ValidatorListSites.cpp	Moved `validator_list_sites` under `admin/status/`.
src/xrpld/rpc/handlers/admin/status/ValidatorInfo.cpp	Moved `validator_info` under `admin/status/`.
src/xrpld/rpc/handlers/admin/status/Print.cpp	Moved `print` under `admin/status/`.
src/xrpld/rpc/handlers/admin/status/GetCounts.h	New header for `get_counts` shared helper.
src/xrpld/rpc/handlers/admin/status/GetCounts.cpp	Moved/split `get_counts` (and helper) into `admin/status/`.
src/xrpld/rpc/handlers/admin/status/FetchInfo.cpp	Moved `fetch_info` under `admin/status/`.
src/xrpld/rpc/handlers/admin/status/ConsensusInfo.cpp	Moved `consensus_info` under `admin/status/`.
src/xrpld/rpc/handlers/admin/signing/SignFor.cpp	Moved `sign_for` under `admin/signing/`.
src/xrpld/rpc/handlers/admin/signing/Sign.cpp	Moved `sign` under `admin/signing/`.
src/xrpld/rpc/handlers/admin/signing/ChannelAuthorize.cpp	Removed embedded `channel_verify` implementation from this file.
src/xrpld/rpc/handlers/admin/server_control/Stop.cpp	Moved `stop` under `admin/server_control/`.
src/xrpld/rpc/handlers/admin/server_control/LedgerAccept.cpp	Moved `ledger_accept` under `admin/server_control/`.
src/xrpld/rpc/handlers/admin/peer/Peers.cpp	Moved `peers` under `admin/peer/`.
src/xrpld/rpc/handlers/admin/peer/PeerReservationsList.cpp	Split `peer_reservations_list` into its own file.
src/xrpld/rpc/handlers/admin/peer/PeerReservationsDel.cpp	Split `peer_reservations_del` into its own file.
src/xrpld/rpc/handlers/admin/peer/PeerReservationsAdd.cpp	Removed embedded `peer_reservations_del/list` implementations from this file.
src/xrpld/rpc/handlers/admin/peer/Connect.cpp	Moved `connect` under `admin/peer/`.
src/xrpld/rpc/handlers/admin/log/LogRotate.cpp	Moved `logrotate` under `admin/log/`.
src/xrpld/rpc/handlers/admin/log/LogLevel.cpp	Moved `log_level` under `admin/log/`.
src/xrpld/rpc/handlers/admin/keygen/WalletPropose.h	New header for keygen `wallet_propose` helper.
src/xrpld/rpc/handlers/admin/keygen/WalletPropose.cpp	Updated include path for moved `WalletPropose.h`.
src/xrpld/rpc/handlers/admin/keygen/ValidationCreate.cpp	Moved `validation_create` under `admin/keygen/`.
src/xrpld/rpc/handlers/admin/data/LedgerRequest.cpp	Moved `ledger_request` under `admin/data/`.
src/xrpld/rpc/handlers/admin/data/LedgerCleaner.cpp	Moved `ledger_cleaner` under `admin/data/`.
src/xrpld/rpc/handlers/admin/data/CanDelete.cpp	Moved `can_delete` under `admin/data/`.
src/xrpld/rpc/handlers/admin/BlackList.cpp	Moved `blacklist` under `admin/`.
src/xrpld/rpc/handlers/account/OwnerInfo.cpp	Moved `owner_info` under `account/`.
src/xrpld/rpc/handlers/account/NoRippleCheck.cpp	Moved `noripple_check` under `account/`.
src/xrpld/rpc/handlers/account/GatewayBalances.cpp	Moved `gateway_balances` under `account/`.
src/xrpld/rpc/handlers/account/AccountTx.cpp	Renamed internal handler function to `doAccountTx`.
src/xrpld/rpc/handlers/account/AccountOffers.cpp	Moved `account_offers` under `account/`.
src/xrpld/rpc/handlers/account/AccountObjects.cpp	Removed embedded `account_nfts` handler implementation.
src/xrpld/rpc/handlers/account/AccountNFTs.cpp	New standalone handler file for `account_nfts`.
src/xrpld/rpc/handlers/account/AccountLines.cpp	Moved `account_lines` under `account/`.
src/xrpld/rpc/handlers/account/AccountInfo.cpp	Moved `account_info` under `account/`.
src/xrpld/rpc/handlers/account/AccountCurrencies.cpp	Moved `account_currencies` under `account/`.
src/xrpld/rpc/handlers/account/AccountChannels.cpp	Moved `account_channels` under `account/`.
src/xrpld/rpc/detail/Handler.cpp	Updated includes and handler registration (`account_tx` -> `doAccountTx`, moved `Version.h`).
src/xrpld/overlay/detail/OverlayImpl.cpp	Updated include path for `GetCounts.h` after refactor.
src/test/rpc/KeyGeneration_test.cpp	Updated include path for moved `WalletPropose.h`.
.github/scripts/rename/copyright.sh	Updated paths for moved handler files referenced by the script.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

mvadari added 2 commits March 23, 2026 21:53

move each RPC into its own file

25c3ae7

move handlers into separate subfolders

f38c9da

mvadari requested a review from Tapanito March 24, 2026 04:55

mvadari added 2 commits March 23, 2026 22:09

fix copyright.sh

35ef6cc

doAccountTxJson -> doAccountTx

db1c459

xrplf-ai-reviewer Bot approved these changes Mar 24, 2026

View reviewed changes

Merge branch 'develop' into divide-rpcs

92ff092

Merge branch 'develop' into divide-rpcs

4abf6c9

Tapanito approved these changes Mar 25, 2026

View reviewed changes

mvadari added the Trivial Simple change with minimal effect, or already tested. Only needs one approval. label Mar 25, 2026

github-actions Bot added the PR: has conflicts label Mar 26, 2026

Merge branch 'develop' into divide-rpcs

f1b9841

Copilot AI review requested due to automatic review settings April 2, 2026 22:39

mvadari added the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label Apr 2, 2026

github-actions Bot removed the PR: has conflicts label Apr 2, 2026

Copilot started reviewing on behalf of mvadari April 2, 2026 22:40 View session

Copilot AI reviewed Apr 2, 2026

View reviewed changes

bthomee added this pull request to the merge queue Apr 2, 2026

Merged via the queue into XRPLF:develop with commit 81555d5 Apr 3, 2026
2 of 3 checks passed

marek-foss-neti pushed a commit to marek-foss-neti/rippled that referenced this pull request May 5, 2026

refactor: Reorganize RPC handler files (XRPLF#6628)

a772faf

mvadari added this to the 3.2.0 milestone May 20, 2026

beartec-jpg pushed a commit to beartec-jpg/FalconLedger that referenced this pull request Jun 1, 2026

refactor: Reorganize RPC handler files (XRPLF#6628)

e691796

Navigation Menu

Uh oh!

refactor: Reorganize RPC handler files - #6628

refactor: Reorganize RPC handler files#6628
bthomee merged 7 commits into
XRPLF:developfrom
mvadari:divide-rpcs

mvadari commented Mar 24, 2026

Uh oh!

codecov Bot commented Mar 24, 2026 •

edited

Loading

Uh oh!

Tapanito commented Mar 24, 2026

Uh oh!

xrplf-ai-reviewer Bot left a comment

Uh oh!

Tapanito commented Mar 24, 2026

Uh oh!

github-actions Bot commented Mar 26, 2026

Uh oh!

github-actions Bot commented Apr 2, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

mvadari commented Mar 24, 2026

High Level Overview of Change

Context of Change

API Impact

Uh oh!

codecov Bot commented Mar 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Tapanito commented Mar 24, 2026

Uh oh!

xrplf-ai-reviewer Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Tapanito commented Mar 24, 2026

Uh oh!

github-actions Bot commented Mar 26, 2026

Uh oh!

github-actions Bot commented Apr 2, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov Bot commented Mar 24, 2026 •

edited

Loading