Sponsored Content
Skip to content

refactor: Improve imports to only call the needed helpers - #6624

Merged
bthomee merged 3 commits into
XRPLF:developfrom
mvadari:rearchitect-pre2
Mar 24, 2026
Merged

refactor: Improve imports to only call the needed helpers#6624
bthomee merged 3 commits into
XRPLF:developfrom
mvadari:rearchitect-pre2

Conversation

@mvadari

@mvadari mvadari commented Mar 23, 2026

Copy link
Copy Markdown
Contributor

High Level Overview of Change

This PR simplifies the includes statements after #6453.

There is no real source code change here, only updating includes.

Context of Change

Requested by @Tapanito in #6453 (comment)

API Impact

N/A

@mvadari
mvadari requested a review from Tapanito March 23, 2026 17:14
@mvadari mvadari added the Trivial Simple change with minimal effect, or already tested. Only needs one approval. label Mar 23, 2026
@mvadari mvadari added the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label Mar 23, 2026
@bthomee
bthomee enabled auto-merge March 23, 2026 18:30
@codecov

codecov Bot commented Mar 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.4%. Comparing base (e0dbe90) to head (d7a2c25).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #6624     +/-   ##
=========================================
- Coverage     81.5%   81.4%   -0.0%     
=========================================
  Files          997     997             
  Lines        74416   74416             
  Branches      7561    7557      -4     
=========================================
- Hits         60617   60609      -8     
- Misses       13799   13807      +8     
Files with missing lines Coverage Δ
include/xrpl/ledger/View.h 100.0% <ø> (ø)
include/xrpl/tx/paths/detail/StrandFlow.h 92.4% <ø> (ø)
include/xrpl/tx/transactors/dex/AMMWithdraw.h 100.0% <ø> (ø)
src/libxrpl/ledger/AcceptedLedgerTx.cpp 100.0% <ø> (ø)
src/libxrpl/ledger/BookDirs.cpp 86.7% <ø> (ø)
src/libxrpl/ledger/View.cpp 96.1% <ø> (ø)
src/libxrpl/tx/Transactor.cpp 93.2% <ø> (ø)
src/libxrpl/tx/invariants/InvariantCheck.cpp 95.8% <ø> (ø)
src/libxrpl/tx/invariants/LoanInvariant.cpp 82.5% <ø> (ø)
src/libxrpl/tx/invariants/VaultInvariant.cpp 98.2% <ø> (ø)
... and 66 more

... and 2 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bthomee
bthomee added this pull request to the merge queue Mar 23, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Mar 23, 2026
@bthomee
bthomee added this pull request to the merge queue Mar 23, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Mar 23, 2026
@bthomee
bthomee added this pull request to the merge queue Mar 24, 2026
Merged via the queue into XRPLF:develop with commit 8b986e4 Mar 24, 2026
3 checks passed
@mvadari
mvadari deleted the rearchitect-pre2 branch March 24, 2026 13:55
@mvadari mvadari added this to the 3.2.0 milestone May 20, 2026
beartec-jpg pushed a commit to beartec-jpg/FalconLedger that referenced this pull request Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. Trivial Simple change with minimal effect, or already tested. Only needs one approval.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants