Sponsored Content
Skip to content

fix: Assorted Vault fixes - #6607

Merged
bthomee merged 5 commits into
developfrom
mvadari/vault-fixes
Mar 24, 2026
Merged

fix: Assorted Vault fixes#6607
bthomee merged 5 commits into
developfrom
mvadari/vault-fixes

Conversation

@mvadari

@mvadari mvadari commented Mar 20, 2026

Copy link
Copy Markdown
Contributor

High Level Overview of Change

This PR fixes a bunch of log-line typos and removes a line of dead code.

Context of Change

AI code review

API Impact

N/A

@mvadari
mvadari marked this pull request as ready for review March 24, 2026 17:56
@mvadari
mvadari requested a review from Tapanito March 24, 2026 17:58
@mvadari mvadari added the Trivial Simple change with minimal effect, or already tested. Only needs one approval. label Mar 24, 2026
@mvadari
mvadari requested a review from bthomee March 24, 2026 17:58
@codecov

codecov Bot commented Mar 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.4%. Comparing base (0eedefb) to head (a521bde).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #6607   +/-   ##
=======================================
  Coverage     81.4%   81.4%           
=======================================
  Files          997     997           
  Lines        74410   74409    -1     
  Branches      7562    7555    -7     
=======================================
+ Hits         60598   60606    +8     
+ Misses       13812   13803    -9     
Files with missing lines Coverage Δ
src/libxrpl/ledger/View.cpp 96.1% <ø> (ø)
src/libxrpl/ledger/helpers/VaultHelpers.cpp 100.0% <100.0%> (ø)
src/libxrpl/tx/transactors/vault/VaultDelete.cpp 91.2% <ø> (-0.2%) ⬇️

... and 6 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mvadari mvadari added the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label Mar 24, 2026
@bthomee
bthomee added this pull request to the merge queue Mar 24, 2026
Merged via the queue into develop with commit f7bb401 Mar 24, 2026
3 checks passed
@bthomee
bthomee deleted the mvadari/vault-fixes branch March 24, 2026 22:30
@mvadari mvadari added the AI Triage Bugs and fixes that have been triaged via AI initiatives label Mar 24, 2026
bthomee pushed a commit that referenced this pull request Apr 7, 2026
ximinez pushed a commit that referenced this pull request Apr 10, 2026
@ximinez ximinez modified the milestones: 3.1.3, 3.1.3 (develop) Apr 15, 2026
ximinez pushed a commit that referenced this pull request Apr 22, 2026
beartec-jpg pushed a commit to beartec-jpg/FalconLedger that referenced this pull request Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI Triage Bugs and fixes that have been triaged via AI initiatives Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. Trivial Simple change with minimal effect, or already tested. Only needs one approval.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants