chore: Don't allow files more than 400kb to be added to the repo - #6597
Merged
Conversation
mathbunnyru
force-pushed
the
no_large_files
branch
from
March 19, 2026 18:26
1f97d52 to
32d965f
Compare
mathbunnyru
added
the
Trivial
bthomee
approved these changes
Mar 19, 2026
mathbunnyru
added
the
Ready to merge
bthomee
changed the title
bthomee
enabled auto-merge
March 19, 2026 21:20
beartec-jpg
pushed a commit
to beartec-jpg/FalconLedger
that referenced
this pull request
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
The largest file in the latest
developis https://github.com/XRPLF/rippled/blob/develop/docs/NodeStoreRefactoringCaseStudy.pdfIt's a bit less than 400kb, which is I use as a limit for the hook.
In the future, if we really want to add such files, we should use
git-lfs.This PR doesn't fix the problem completely, since there are files in history that were quite large.
But we'll need to override history, which is quite difficult for contributors, so let's make sure it won't get worse
Context of Change
API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)