Sponsored Content
Skip to content

fix: Assorted Permissioned Domain fixes - #6587

Merged
bthomee merged 2 commits into
developfrom
mvadari/pd-fixes
Mar 24, 2026
Merged

fix: Assorted Permissioned Domain fixes#6587
bthomee merged 2 commits into
developfrom
mvadari/pd-fixes

Conversation

@mvadari

@mvadari mvadari commented Mar 19, 2026

Copy link
Copy Markdown
Contributor

High Level Overview of Change

Removed unnecessary check for slePd initialization (std::make_shared cannot return a nullptr).

Context of Change

AI code review

API Impact

N/A

Removed unnecessary check for slePd initialization.
@mvadari
mvadari marked this pull request as ready for review March 24, 2026 17:59
@mvadari
mvadari requested review from bthomee and oleks-rip March 24, 2026 18:06
@mvadari mvadari added the Trivial Simple change with minimal effect, or already tested. Only needs one approval. label Mar 24, 2026
@codecov

codecov Bot commented Mar 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.5%. Comparing base (0eedefb) to head (df8c386).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #6587   +/-   ##
=======================================
  Coverage     81.4%   81.5%           
=======================================
  Files          997     997           
  Lines        74410   74409    -1     
  Branches      7562    7553    -9     
=======================================
+ Hits         60598   60613   +15     
+ Misses       13812   13796   -16     
Files with missing lines Coverage Δ
...tors/permissioned_domain/PermissionedDomainSet.cpp 100.0% <ø> (ø)

... and 7 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mvadari mvadari added the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label Mar 24, 2026
@bthomee
bthomee added this pull request to the merge queue Mar 24, 2026
Merged via the queue into develop with commit 85a4015 Mar 24, 2026
3 checks passed
@bthomee
bthomee deleted the mvadari/pd-fixes branch March 24, 2026 22:30
@mvadari mvadari added the AI Triage Bugs and fixes that have been triaged via AI initiatives label Mar 24, 2026
bthomee pushed a commit that referenced this pull request Apr 7, 2026
@ximinez ximinez modified the milestones: 3.1.3, 3.1.3 (develop) Apr 15, 2026
beartec-jpg pushed a commit to beartec-jpg/FalconLedger that referenced this pull request Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI Triage Bugs and fixes that have been triaged via AI initiatives Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. Trivial Simple change with minimal effect, or already tested. Only needs one approval.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants