Sponsored Content
Skip to content

fix: Address remaining issue after clang-tidy merge - #6582

Merged
bthomee merged 1 commit into
XRPLF:developfrom
godexsoft:bugfix/clang-tidy-extrafix
Mar 18, 2026
Merged

fix: Address remaining issue after clang-tidy merge#6582
bthomee merged 1 commit into
XRPLF:developfrom
godexsoft:bugfix/clang-tidy-extrafix

Conversation

@godexsoft

Copy link
Copy Markdown
Contributor

High Level Overview of Change

This PR fixes an issue that arose after merging some checks.

API Impact

No impact.

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

@godexsoft godexsoft added the Trivial Simple change with minimal effect, or already tested. Only needs one approval. label Mar 18, 2026
@codecov

codecov Bot commented Mar 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.7%. Comparing base (57e4cbb) to head (c5cdf17).
⚠️ Report is 5 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #6582   +/-   ##
=======================================
  Coverage     79.7%   79.7%           
=======================================
  Files          878     878           
  Lines        68116   68116           
  Branches      7563    7556    -7     
=======================================
+ Hits         54300   54316   +16     
+ Misses       13816   13800   -16     

see 4 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@godexsoft godexsoft added the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label Mar 18, 2026
@bthomee bthomee changed the title fix: Issue after clang-tidy merge fix: Address remaining issue after clang-tidy merge Mar 18, 2026
@bthomee
bthomee added this pull request to the merge queue Mar 18, 2026
Merged via the queue into XRPLF:develop with commit 12954d5 Mar 18, 2026
3 checks passed
@mvadari mvadari added this to the 3.2.0 milestone May 20, 2026
beartec-jpg pushed a commit to beartec-jpg/FalconLedger that referenced this pull request Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. Trivial Simple change with minimal effect, or already tested. Only needs one approval.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants