Sponsored Content
Skip to content

ci: Don't check PR title for drafts - #6573

Merged
bthomee merged 3 commits into
XRPLF:developfrom
mathbunnyru:no_pr_title_draft
Mar 18, 2026
Merged

ci: Don't check PR title for drafts#6573
bthomee merged 3 commits into
XRPLF:developfrom
mathbunnyru:no_pr_title_draft

Conversation

@mathbunnyru

Copy link
Copy Markdown
Contributor

High Level Overview of Change

This makes PR title check not run on draft PRs.

Context of Change

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

@mathbunnyru
mathbunnyru marked this pull request as ready for review March 18, 2026 11:58
@mathbunnyru
mathbunnyru marked this pull request as draft March 18, 2026 11:59
@mathbunnyru
mathbunnyru marked this pull request as ready for review March 18, 2026 12:00
@mathbunnyru mathbunnyru added the Trivial Simple change with minimal effect, or already tested. Only needs one approval. label Mar 18, 2026
@mathbunnyru
mathbunnyru marked this pull request as draft March 18, 2026 14:13
@mathbunnyru
mathbunnyru marked this pull request as ready for review March 18, 2026 14:35
@mathbunnyru mathbunnyru added the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label Mar 18, 2026
@bthomee
bthomee enabled auto-merge (squash) March 18, 2026 17:02
@bthomee
bthomee merged commit 697fb64 into XRPLF:develop Mar 18, 2026
1 check passed
@codecov

codecov Bot commented Mar 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.7%. Comparing base (57e4cbb) to head (419e215).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #6573   +/-   ##
=======================================
  Coverage     79.7%   79.7%           
=======================================
  Files          878     878           
  Lines        68116   68116           
  Branches      7563    7554    -9     
=======================================
+ Hits         54300   54316   +16     
+ Misses       13816   13800   -16     

see 7 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mvadari mvadari added this to the 3.2.0 milestone May 20, 2026
beartec-jpg pushed a commit to beartec-jpg/FalconLedger that referenced this pull request Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. Trivial Simple change with minimal effect, or already tested. Only needs one approval.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants