Sponsored Content
Skip to content

fix: Assorted Oracle fixes - #6570

Merged
bthomee merged 5 commits into
developfrom
mvadari/oracle-fixes
Mar 22, 2026
Merged

fix: Assorted Oracle fixes#6570
bthomee merged 5 commits into
developfrom
mvadari/oracle-fixes

Conversation

@mvadari

@mvadari mvadari commented Mar 17, 2026

Copy link
Copy Markdown
Contributor

High Level Overview of Change

This PR:

  • Switches a potential negative variable from unsigned to signed
  • Fixes some inaccurate comments
  • Improves performance of get_aggregate_price by preventing unnecessary repeat computation

Context of Change

AI code review

API Impact

N/A

@mvadari
mvadari marked this pull request as ready for review March 21, 2026 00:37
@mvadari
mvadari requested a review from bthomee March 21, 2026 00:42
@mvadari mvadari added the Trivial Simple change with minimal effect, or already tested. Only needs one approval. label Mar 21, 2026
@codecov

codecov Bot commented Mar 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.4%. Comparing base (cf2eb14) to head (92cab2e).
⚠️ Report is 8 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #6570   +/-   ##
=======================================
  Coverage     81.4%   81.4%           
=======================================
  Files          988     988           
  Lines        74411   74411           
  Branches      7560    7557    -3     
=======================================
+ Hits         60599   60605    +6     
+ Misses       13812   13806    -6     
Files with missing lines Coverage Δ
src/libxrpl/tx/transactors/oracle/OracleSet.cpp 98.8% <100.0%> (ø)
src/xrpld/rpc/handlers/GetAggregatePrice.cpp 99.4% <100.0%> (ø)

... and 2 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread src/libxrpl/tx/transactors/oracle/OracleSet.cpp
Comment thread src/xrpld/rpc/handlers/GetAggregatePrice.cpp
@mvadari mvadari added the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label Mar 22, 2026
@bthomee
bthomee added this pull request to the merge queue Mar 22, 2026
Merged via the queue into develop with commit be1cc48 Mar 22, 2026
3 checks passed
@bthomee
bthomee deleted the mvadari/oracle-fixes branch March 22, 2026 18:29
Tapanito pushed a commit that referenced this pull request Mar 24, 2026
@mvadari mvadari added the AI Triage Bugs and fixes that have been triaged via AI initiatives label Mar 24, 2026
bthomee pushed a commit that referenced this pull request Apr 7, 2026
ximinez pushed a commit that referenced this pull request Apr 10, 2026
@ximinez ximinez modified the milestones: 3.1.3, 3.1.3 (develop) Apr 15, 2026
ximinez pushed a commit that referenced this pull request Apr 22, 2026
beartec-jpg pushed a commit to beartec-jpg/FalconLedger that referenced this pull request Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI Triage Bugs and fixes that have been triaged via AI initiatives Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. Trivial Simple change with minimal effect, or already tested. Only needs one approval.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants