Sponsored Content
Skip to content

fix: Make assorted NFT fixes - #6566

Merged
bthomee merged 6 commits into
developfrom
mvadari/nft-ai-fixes
Mar 18, 2026
Merged

fix: Make assorted NFT fixes#6566
bthomee merged 6 commits into
developfrom
mvadari/nft-ai-fixes

Conversation

@mvadari

@mvadari mvadari commented Mar 17, 2026

Copy link
Copy Markdown
Contributor

High Level Overview of Change

This PR:

  • Removes a set of unnecessary brackets in the initialization of an std::uint32_t
  • Fixes a couple of incorrect flags (same value, just wrong variables - so no amendment needed)

Context of Change

AI review of xrpld

API Impact

N/A

@mvadari
mvadari marked this pull request as ready for review March 17, 2026 21:17
@mvadari
mvadari requested a review from bthomee March 17, 2026 21:23
@mvadari mvadari added the Trivial Simple change with minimal effect, or already tested. Only needs one approval. label Mar 17, 2026
@codecov

codecov Bot commented Mar 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.8%. Comparing base (dcaef82) to head (2bc2d75).
⚠️ Report is 20 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #6566     +/-   ##
=========================================
- Coverage     79.8%   79.8%   -0.0%     
=========================================
  Files          878     878             
  Lines        68031   68031             
  Branches      7557    7575     +18     
=========================================
- Hits         54298   54281     -17     
- Misses       13733   13750     +17     
Files with missing lines Coverage Δ
include/xrpl/tx/transactors/nft/NFTokenUtils.h 100.0% <ø> (ø)
.../libxrpl/tx/transactors/nft/NFTokenCreateOffer.cpp 100.0% <100.0%> (ø)
src/libxrpl/tx/transactors/nft/NFTokenUtils.cpp 87.1% <100.0%> (ø)

... and 8 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mvadari mvadari added the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label Mar 18, 2026
@bthomee bthomee changed the title fix: Assorted NFT fixes fix: Make assorted NFT fixes Mar 18, 2026
@bthomee
bthomee enabled auto-merge (squash) March 18, 2026 14:29
@bthomee
bthomee merged commit b92a9a3 into develop Mar 18, 2026
1 check passed
@bthomee
bthomee deleted the mvadari/nft-ai-fixes branch March 18, 2026 14:48
@mvadari mvadari added the AI Triage Bugs and fixes that have been triaged via AI initiatives label Mar 24, 2026
bthomee pushed a commit that referenced this pull request Apr 7, 2026
This change:
* Removes a set of unnecessary brackets in the initialization of an `std::uint32_t`.
* Fixes a couple of incorrect flags (same value, just wrong variables - so no amendment needed).
ximinez pushed a commit that referenced this pull request Apr 10, 2026
This change:
* Removes a set of unnecessary brackets in the initialization of an `std::uint32_t`.
* Fixes a couple of incorrect flags (same value, just wrong variables - so no amendment needed).
@ximinez ximinez modified the milestones: 3.1.3, 3.1.3 (develop) Apr 15, 2026
ximinez pushed a commit that referenced this pull request Apr 22, 2026
This change:
* Removes a set of unnecessary brackets in the initialization of an `std::uint32_t`.
* Fixes a couple of incorrect flags (same value, just wrong variables - so no amendment needed).
beartec-jpg pushed a commit to beartec-jpg/FalconLedger that referenced this pull request Jun 1, 2026
This change:
* Removes a set of unnecessary brackets in the initialization of an `std::uint32_t`.
* Fixes a couple of incorrect flags (same value, just wrong variables - so no amendment needed).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI Triage Bugs and fixes that have been triaged via AI initiatives Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. Trivial Simple change with minimal effect, or already tested. Only needs one approval.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants