ci: Fix build errors on windows - #6562
Merged
Merged
Conversation
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
a1q123456
added
the
Trivial
bthomee
approved these changes
Mar 17, 2026
a1q123456
added
the
Ready to merge
a1q123456
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #6562 +/- ##
=========================================
- Coverage 79.9% 79.8% -0.0%
=========================================
Files 878 878
Lines 67893 67893
Branches 7547 7551 +4
=========================================
- Hits 54217 54209 -8
- Misses 13676 13684 +8 see 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
pratikmankawde
added a commit
that referenced
this pull request
Apr 22, 2026
PR #6562 disabled `_CRTDBG_MAP_ALLOC` in CI to work around a macro collision in `boost/context/pooled_fixedsize_stack.hpp`. The previous commit resolves that collision at the source by narrowing the Boost.Coroutine2 include so the broken header is no longer pulled in. With the root cause fixed, restore the original define scope. CI now exercises the same Debug preprocessor configuration as local MSVC builds, guarding against regressions of the same bug.
6 tasks
beartec-jpg
pushed a commit
to beartec-jpg/FalconLedger
that referenced
this pull request
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This PR stops defining the macro
_CRTDBG_MAP_ALLOCon windows when building in ci.Context of Change
We're getting some build errors on Windows after we redeployed the windows build runners. https://github.com/XRPLF/rippled/actions/runs/23182100319/job/67376175628
An MSVC update seems to have added
crtdbg.hinclude dependency to<string>. As the result,pooled_fixedsize_stackinboost(https://www.boost.org/doc/libs/1_89_0/boost/context/pooled_fixedsize_stack.hpp) has stopped working on windows because it calls a member functionmallocwhich conflicts with the macro namemallocintroduced bycrtdbg.h.The purpose of
_CRTDBG_MAP_ALLOCis to use debugmallocandreallocto help debug memory leaks. However, it makes no sense to use it in CI because we don't run the debug builds produced by CI, also, never have we directly includedcrtdbg.hand used its functionalities.API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)