Sponsored Content
Skip to content

fix: Remove nonexistent boost::coroutine2 library - #6561

Merged
bthomee merged 2 commits into
developfrom
legleux/fix-conan
Mar 17, 2026
Merged

fix: Remove nonexistent boost::coroutine2 library#6561
bthomee merged 2 commits into
developfrom
legleux/fix-conan

Conversation

@legleux

@legleux legleux commented Mar 17, 2026

Copy link
Copy Markdown
Contributor

High Level Overview of Change

Removes coroutine2 library that Conan doesn't know about.

Context of Change

Apparently coroutine is provided by context and if you try to use libxrpl it will error out because the coroutine2 lib is not being exposed.

There's no coroutine2 in the Boost Conan package

@pratikmankawde pratikmankawde left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@codecov

codecov Bot commented Mar 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.8%. Comparing base (a518589) to head (72671e8).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #6561   +/-   ##
=======================================
  Coverage     79.8%   79.8%           
=======================================
  Files          878     878           
  Lines        67892   67892           
  Branches      7554    7551    -3     
=======================================
+ Hits         54200   54203    +3     
+ Misses       13692   13689    -3     

see 3 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bthomee bthomee added the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label Mar 17, 2026
@bthomee bthomee changed the title fix: Remove nonexistent Conan component fix: Remove nonexistent boost::coroutine2 library Mar 17, 2026
@bthomee
bthomee enabled auto-merge (squash) March 17, 2026 18:21
@bthomee
bthomee merged commit b523770 into develop Mar 17, 2026
1 check passed
@bthomee
bthomee deleted the legleux/fix-conan branch March 17, 2026 18:46
@mvadari mvadari added this to the 3.2.0 milestone May 20, 2026
beartec-jpg pushed a commit to beartec-jpg/FalconLedger that referenced this pull request Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants