refactor: Use ReadView instead of ApplyView in authorizedDepositPreauth() - #6560
Merged
bthomee merged 2 commits intoMar 17, 2026
Merged
Conversation
mvadari
approved these changes
Mar 17, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #6560 +/- ##
=========================================
- Coverage 79.8% 79.8% -0.0%
=========================================
Files 878 878
Lines 68026 68026
Branches 7553 7555 +2
=========================================
- Hits 54306 54300 -6
- Misses 13720 13726 +6
🚀 New features to boost your workflow:
|
Contributor
|
@tequdev is this PR ready to merge? |
Member
Author
yes |
beartec-jpg
pushed a commit
to beartec-jpg/FalconLedger
that referenced
this pull request
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Change the parameter type of
credentials::authorizedDepositPreauthfromApplyView const&toReadView const&, since the function only performs read operations on the view.Context of Change
authorizedDepositPreauthonly callsview.read()andview.exists(), which areReadViewmethods. UsingApplyViewwas unnecessarily restrictive and misleading about the function's intent. Thischange narrows the interface to the minimal required type.