Sponsored Content
Skip to content

refactor: Use ReadView instead of ApplyView in authorizedDepositPreauth() - #6560

Merged
bthomee merged 2 commits into
XRPLF:developfrom
tequdev:refactor-authorizedDepositPreauth-readview
Mar 17, 2026
Merged

refactor: Use ReadView instead of ApplyView in authorizedDepositPreauth()#6560
bthomee merged 2 commits into
XRPLF:developfrom
tequdev:refactor-authorizedDepositPreauth-readview

Conversation

@tequdev

@tequdev tequdev commented Mar 17, 2026

Copy link
Copy Markdown
Member

High Level Overview of Change

Change the parameter type of credentials::authorizedDepositPreauth from ApplyView const& to ReadView const&, since the function only performs read operations on the view.

Context of Change

authorizedDepositPreauth only calls view.read() and view.exists(), which are ReadView methods. Using ApplyView was unnecessarily restrictive and misleading about the function's intent. This
change narrows the interface to the minimal required type.

@mvadari mvadari added the Trivial Simple change with minimal effect, or already tested. Only needs one approval. label Mar 17, 2026
@codecov

codecov Bot commented Mar 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.8%. Comparing base (013c2d6) to head (e9486d3).
⚠️ Report is 3 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #6560     +/-   ##
=========================================
- Coverage     79.8%   79.8%   -0.0%     
=========================================
  Files          878     878             
  Lines        68026   68026             
  Branches      7553    7555      +2     
=========================================
- Hits         54306   54300      -6     
- Misses       13720   13726      +6     
Files with missing lines Coverage Δ
src/libxrpl/ledger/CredentialHelpers.cpp 97.6% <100.0%> (ø)

... and 2 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mvadari

mvadari commented Mar 17, 2026

Copy link
Copy Markdown
Contributor

@tequdev is this PR ready to merge?

@tequdev

tequdev commented Mar 17, 2026

Copy link
Copy Markdown
Member Author

@tequdev is this PR ready to merge?

yes

@mvadari mvadari added the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label Mar 17, 2026
@bthomee
bthomee merged commit b129b71 into XRPLF:develop Mar 17, 2026
1 check passed
@mvadari mvadari added this to the 3.2.0 milestone May 20, 2026
beartec-jpg pushed a commit to beartec-jpg/FalconLedger that referenced this pull request Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. Trivial Simple change with minimal effect, or already tested. Only needs one approval.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants