refactor: Add const qualifier to SLE in verifyDepositPreauth parameter - #6555
Merged
bthomee merged 3 commits intoMar 17, 2026
Merged
Conversation
tequdev
changed the title
verifyDepositPreauth parameter
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #6555 +/- ##
=======================================
Coverage 79.8% 79.8%
=======================================
Files 878 878
Lines 68026 68026
Branches 7556 7552 -4
=======================================
+ Hits 54299 54304 +5
+ Misses 13727 13722 -5
... and 3 files with indirect coverage changes 🚀 New features to boost your workflow:
|
mvadari
approved these changes
Mar 17, 2026
mvadari
added
Ready to merge
bthomee
enabled auto-merge
March 17, 2026 15:53
bthomee
enabled auto-merge (squash)
March 17, 2026 19:16
oleks-rip
reviewed
Mar 17, 2026
| AccountID const& src, | ||
| AccountID const& dst, | ||
| std::shared_ptr<SLE> const& sleDst, | ||
| std::shared_ptr<SLE const> const& sleDst, |
Contributor
There was a problem hiding this comment.
std::shared_ptr<SLE const> const& sleDst, -> SLE::const_ref sleDst
| AccountID const& src, | ||
| AccountID const& dst, | ||
| std::shared_ptr<SLE> const& sleDst, | ||
| std::shared_ptr<SLE const> const& sleDst, |
oleks-rip
removed
the
Ready to merge
beartec-jpg
pushed a commit
to beartec-jpg/FalconLedger
that referenced
this pull request
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Add
constqualifier toSLEin theverifyDepositPreauthfunction parameter, changingstd::shared_ptr<SLE> const&tostd::shared_ptr<SLE const> const&.Context of Change
The
sleDstparameter inverifyDepositPreauthis not modified within the function body. Usingstd::shared_ptr<SLE const>instead ofstd::shared_ptr<SLE>enforces const-correctness at the typelevel, preventing accidental mutation of the ledger entry through this pointer.
This is a refactor to improve const-correctness with no behavioral change.
#5887 (comment)