Sponsored Content
Skip to content

fix: Use correct format and event for workflows for release tags - #6554

Merged
bthomee merged 3 commits into
developfrom
legleux/fix-tag-workflow
Mar 19, 2026
Merged

fix: Use correct format and event for workflows for release tags#6554
bthomee merged 3 commits into
developfrom
legleux/fix-tag-workflow

Conversation

@legleux

@legleux legleux commented Mar 17, 2026

Copy link
Copy Markdown
Contributor

High Level Overview of Change

Trying to fix 2 issues:

  1. Conan recipes for release would never be uploaded since there's no tag event in GitHub.
  2. on-tag.yml would never trigger unless we start tagging releases prefixed with v.

@legleux
legleux requested review from bthomee and mathbunnyru March 17, 2026 02:28
@codecov

codecov Bot commented Mar 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.4%. Comparing base (b1e5ba0) to head (a20e046).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #6554     +/-   ##
=========================================
- Coverage     81.5%   81.4%   -0.0%     
=========================================
  Files          988     988             
  Lines        74411   74411             
  Branches      7560    7559      -1     
=========================================
- Hits         60610   60599     -11     
- Misses       13801   13812     +11     

see 5 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@legleux
legleux enabled auto-merge (squash) March 17, 2026 14:38
@bthomee
bthomee disabled auto-merge March 17, 2026 14:51
Comment thread .github/workflows/on-tag.yml Outdated
@legleux
legleux force-pushed the legleux/fix-tag-workflow branch from 73cc696 to 19d3d43 Compare March 17, 2026 16:33
Comment thread .github/workflows/reusable-upload-recipe.yml Outdated
Comment thread .github/workflows/reusable-upload-recipe.yml
@mathbunnyru

Copy link
Copy Markdown
Contributor

@scutuatua-crypto, please stop spamming with PR approvals

@legleux
legleux force-pushed the legleux/fix-tag-workflow branch from 4105dd4 to a20e046 Compare March 18, 2026 22:57
@legleux
legleux requested a review from mathbunnyru March 18, 2026 22:58
@bthomee
bthomee added this pull request to the merge queue Mar 19, 2026
Merged via the queue into develop with commit 6efd312 Mar 19, 2026
3 checks passed
@bthomee
bthomee deleted the legleux/fix-tag-workflow branch March 19, 2026 10:45
@mvadari mvadari added this to the 3.2.0 milestone May 20, 2026
beartec-jpg pushed a commit to beartec-jpg/FalconLedger that referenced this pull request Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants