Sponsored Content
Skip to content

refactor: Remove dead code in escrow helper logic - #6553

Merged
bthomee merged 2 commits into
developfrom
mvadari/escrow-dead
Mar 17, 2026
Merged

refactor: Remove dead code in escrow helper logic#6553
bthomee merged 2 commits into
developfrom
mvadari/escrow-dead

Conversation

@mvadari

@mvadari mvadari commented Mar 16, 2026

Copy link
Copy Markdown
Contributor

High Level Overview of Change

This PR removes a piece of dead code and a redundant variable.

Context of Change

AI code review

API Impact

N/A

@mvadari
mvadari requested a review from bthomee March 16, 2026 21:17
@mvadari mvadari added the Trivial Simple change with minimal effect, or already tested. Only needs one approval. label Mar 16, 2026
Comment thread src/libxrpl/tx/transactors/escrow/EscrowHelpers.h
@codecov

codecov Bot commented Mar 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.8%. Comparing base (0a9513e) to head (18e7580).
⚠️ Report is 32 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #6553     +/-   ##
=========================================
- Coverage     79.8%   79.8%   -0.0%     
=========================================
  Files          878     878             
  Lines        67893   67892      -1     
  Branches      7551    7551             
=========================================
- Hits         54209   54208      -1     
  Misses       13684   13684             
Files with missing lines Coverage Δ
src/libxrpl/tx/transactors/escrow/EscrowHelpers.h 98.7% <100.0%> (-<0.1%) ⬇️

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread src/libxrpl/tx/transactors/escrow/EscrowHelpers.h
@mvadari mvadari added the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label Mar 17, 2026
@bthomee
bthomee added this pull request to the merge queue Mar 17, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Mar 17, 2026
@bthomee
bthomee enabled auto-merge (squash) March 17, 2026 17:57
@bthomee
bthomee merged commit a518589 into develop Mar 17, 2026
1 check passed
@bthomee
bthomee deleted the mvadari/escrow-dead branch March 17, 2026 18:13
@mvadari mvadari added the AI Triage Bugs and fixes that have been triaged via AI initiatives label Mar 24, 2026
@mvadari mvadari added this to the 3.2.0 milestone May 20, 2026
beartec-jpg pushed a commit to beartec-jpg/FalconLedger that referenced this pull request Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI Triage Bugs and fixes that have been triaged via AI initiatives Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. Trivial Simple change with minimal effect, or already tested. Only needs one approval.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants