refactor: Assorted small DID fixes - #6552
Merged
Merged
Conversation
addSLE function static in DIDSet
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #6552 +/- ##
=======================================
Coverage 79.8% 79.8%
=======================================
Files 878 878
Lines 67893 67893
Branches 7550 7550
=======================================
+ Hits 54210 54211 +1
+ Misses 13683 13682 -1
🚀 New features to boost your workflow:
|
bthomee
approved these changes
Mar 17, 2026
bthomee
enabled auto-merge (squash)
March 17, 2026 14:19
beartec-jpg
pushed a commit
to beartec-jpg/FalconLedger
that referenced
this pull request
Jun 1, 2026
This change: * Makes `addSLE` in `DIDSet` a static function, instead of a free function. * Renames `Attestation` to `Data` everywhere (an artifact of a previous name for the field). * Actually runs a set of tests that were not included in the `run` function of `DID_test`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This PR:
addSLEinDIDSeta static function, instead of a free function.AttestationtoDataeverywhere (an artifact of a previous name for the field).runfunction ofDID_test.Context of Change
AI code review
API Impact
N/A