Sponsored Content
Skip to content

fix: Remove a newline from logging statement in changeSpotPrice calculation - #6547

Merged
bthomee merged 2 commits into
developfrom
mvadari/ammhelpers-endl
Mar 13, 2026
Merged

fix: Remove a newline from logging statement in changeSpotPrice calculation#6547
bthomee merged 2 commits into
developfrom
mvadari/ammhelpers-endl

Conversation

@mvadari

@mvadari mvadari commented Mar 12, 2026

Copy link
Copy Markdown
Contributor

High Level Overview of Change

Removed unnecessary newline in logging statement.

std::endl is unneeded in JLOG, since it automatically places a newline at the end of the string. So it's an unnecessary flush.

Context of Change

AI review triage

@codecov

codecov Bot commented Mar 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.8%. Comparing base (0446bef) to head (1b081e4).
⚠️ Report is 48 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #6547     +/-   ##
=========================================
- Coverage     79.8%   79.8%   -0.0%     
=========================================
  Files          878     878             
  Lines        67887   67887             
  Branches      7549    7551      +2     
=========================================
- Hits         54206   54204      -2     
- Misses       13681   13683      +2     
Files with missing lines Coverage Δ
include/xrpl/tx/transactors/dex/AMMHelpers.h 96.0% <100.0%> (ø)
src/libxrpl/tx/transactors/dex/AMMDeposit.cpp 96.4% <ø> (ø)

... and 2 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mvadari
mvadari force-pushed the mvadari/ammhelpers-endl branch from c1c020f to 1b081e4 Compare March 13, 2026 17:53
@mvadari mvadari added the Trivial Simple change with minimal effect, or already tested. Only needs one approval. label Mar 13, 2026
@mvadari
mvadari requested a review from bthomee March 13, 2026 17:54
@mvadari mvadari added the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label Mar 13, 2026
@bthomee bthomee changed the title fix: Logging statement in changeSpotPrice calculation fix: Remove a newline from logging statement in changeSpotPrice calculation Mar 13, 2026
@bthomee
bthomee enabled auto-merge (squash) March 13, 2026 18:06
@bthomee
bthomee merged commit 1bf9e6e into develop Mar 13, 2026
1 check passed
@bthomee
bthomee deleted the mvadari/ammhelpers-endl branch March 13, 2026 18:12
@mvadari mvadari added the AI Triage Bugs and fixes that have been triaged via AI initiatives label Mar 24, 2026
@mvadari mvadari added this to the 3.2.0 milestone May 20, 2026
beartec-jpg pushed a commit to beartec-jpg/FalconLedger that referenced this pull request Jun 1, 2026
…culation (XRPLF#6547)

This change removes an unnecessary newline in a logging statement. Namely, `std::endl` is unneeded in `JLOG`, since it automatically places a newline at the end of the string.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI Triage Bugs and fixes that have been triaged via AI initiatives Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. Trivial Simple change with minimal effect, or already tested. Only needs one approval.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants