fix: Remove a newline from logging statement in changeSpotPrice calculation - #6547
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #6547 +/- ##
=========================================
- Coverage 79.8% 79.8% -0.0%
=========================================
Files 878 878
Lines 67887 67887
Branches 7549 7551 +2
=========================================
- Hits 54206 54204 -2
- Misses 13681 13683 +2
🚀 New features to boost your workflow:
|
Removed unnecessary newline in logging statement.
mvadari
force-pushed
the
mvadari/ammhelpers-endl
branch
from
March 13, 2026 17:53
c1c020f to
1b081e4
Compare
bthomee
approved these changes
Mar 13, 2026
changeSpotPrice calculation
bthomee
enabled auto-merge (squash)
March 13, 2026 18:06
beartec-jpg
pushed a commit
to beartec-jpg/FalconLedger
that referenced
this pull request
Jun 1, 2026
…culation (XRPLF#6547) This change removes an unnecessary newline in a logging statement. Namely, `std::endl` is unneeded in `JLOG`, since it automatically places a newline at the end of the string.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Removed unnecessary newline in logging statement.
std::endl is unneeded in JLOG, since it automatically places a newline at the end of the string. So it's an unnecessary flush.
Context of Change
AI review triage