chore: Add comment explaining why ammLPHolds is called twice - #6546
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #6546 +/- ##
=========================================
- Coverage 79.8% 79.8% -0.0%
=========================================
Files 878 878
Lines 67893 67892 -1
Branches 7551 7551
=========================================
- Hits 54209 54208 -1
Misses 13684 13684
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
mvadari
added
Ready to merge
yinyiqian1
requested changes
Mar 17, 2026
Contributor
There was a problem hiding this comment.
verifyAndAdjustLPTokenBalance modifies the ledger state. It rounds the LPToken balance.
When fixAMMClawbackRounding is enabled, lpTokenBalance was retrieved twice on purpose before the refactor:
The rounding function verifyAndAdjustLPTokenBalance happens bewteen the two ammLPHolds functions.
So if there's rounding happening, the second ammLPHolds will return a different number from the first ammLPHolds
yinyiqian1
removed
the
Ready to merge
mvadari
removed
the
Trivial
mvadari
force-pushed
the
mvadari/ammwithdraw-redundance
branch
from
March 17, 2026 18:20
a55afcb to
b48fb7c
Compare
mvadari
changed the title
AMMClawbackammLPHolds is called twice
mvadari
added
the
Trivial
yinyiqian1
approved these changes
Mar 17, 2026
mvadari
added
the
Ready to merge
beartec-jpg
pushed a commit
to beartec-jpg/FalconLedger
that referenced
this pull request
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This PR notes that in
AMMClawback,ammLPHoldswas called twice on purposeContext of Change
AI review triage