refactor: Remove dead code in CreateOffer - #6541
Merged
Merged
Conversation
Removed redundant check for account creating trustline to itself.
mvadari
added
the
Trivial
mvadari
changed the title
CreateOfferCreateOffer
bthomee
approved these changes
Mar 12, 2026
mvadari
added
the
Ready to merge
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #6541 +/- ##
=========================================
- Coverage 79.8% 79.8% -0.0%
=========================================
Files 878 878
Lines 67889 67887 -2
Branches 7551 7555 +4
=========================================
- Hits 54206 54195 -11
- Misses 13683 13692 +9
... and 4 files with indirect coverage changes 🚀 New features to boost your workflow:
|
mvadari
added
the
AI Triage
beartec-jpg
pushed a commit
to beartec-jpg/FalconLedger
that referenced
this pull request
Jun 1, 2026
Removed redundant check for account creating trustline to itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Removed redundant check for account creating an offer for a token it issues.
Context of Change
AI code review spotted the dead code
API Impact
N/A