⚡ Quick Guide: refactor: Enable remaining clang-tidy `cppcoreguidelines` checks by godexsoft · Pull Request #6538 · XRPLF/rippled · GitHub

godexsoft · 2026-03-12T17:07:13Z

High Level Overview of Change

This PR attempts to enable remaining clang-tidy cppcoreguidelines checks.

API Impact

No impact.

codecov · 2026-03-12T17:33:19Z

Codecov Report

❌ Patch coverage is 75.10730% with 58 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.8%. Comparing base (b523770) to head (27134ea).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines	Patch %	Lines
src/libxrpl/shamap/SHAMapDelta.cpp	30.0%	7 Missing ⚠️
src/xrpld/app/rdb/backend/detail/Node.cpp	56.2%	7 Missing ⚠️
src/xrpld/overlay/detail/OverlayImpl.cpp	33.3%	6 Missing ⚠️
src/xrpld/overlay/detail/PeerImp.cpp	0.0%	6 Missing ⚠️
src/libxrpl/basics/Archive.cpp	0.0%	5 Missing ⚠️
src/libxrpl/shamap/SHAMapSync.cpp	76.2%	5 Missing ⚠️
src/xrpld/app/ledger/detail/LedgerMaster.cpp	0.0%	4 Missing ⚠️
src/libxrpl/beast/insight/StatsDCollector.cpp	0.0%	3 Missing ⚠️
src/xrpld/app/ledger/detail/LedgerCleaner.cpp	0.0%	3 Missing ⚠️
src/libxrpl/json/json_reader.cpp	83.3%	2 Missing ⚠️
... and 8 more

Additional details and impacted files

@@            Coverage Diff            @@
##           develop   #6538     +/-   ##
=========================================
- Coverage     79.8%   79.8%   -0.0%     
=========================================
  Files          878     878             
  Lines        67892   68026    +134     
  Branches      7554    7557      +3     
=========================================
+ Hits         54200   54293     +93     
- Misses       13692   13733     +41

Files with missing lines	Coverage Δ
include/xrpl/basics/safe_cast.h	`88.9% <100.0%> (+7.1%)`	⬆️
include/xrpl/beast/core/List.h	`92.6% <ø> (+0.1%)`	⬆️
include/xrpl/json/json_value.h	`98.5% <ø> (ø)`
include/xrpl/json/json_writer.h	`100.0% <ø> (ø)`
include/xrpl/protocol/PublicKey.h	`80.5% <ø> (ø)`
include/xrpl/protocol/STAccount.h	`84.6% <ø> (ø)`
include/xrpl/protocol/STObject.h	`93.7% <ø> (ø)`
include/xrpl/protocol/SecretKey.h	`66.7% <ø> (ø)`
include/xrpl/protocol/Seed.h	`100.0% <ø> (ø)`
include/xrpl/protocol/detail/STVar.h	`100.0% <ø> (ø)`
... and 99 more

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

kuznetsss

👍 🚀

Fixes by AI Enable checks Few small fixes Add safe_downcast wrapper and use it Fix more clang-tidy Fix review suggestion

…LF#6538)

godexsoft added the DraftRunCI Normally CI does not run on draft PRs. This opts in. label Mar 12, 2026