Sponsored Content
Skip to content

feat: Create new transaction testing framework TxTest - #6537

Merged
bthomee merged 72 commits into
developfrom
a1q123456/new-jtx
Apr 28, 2026
Merged

feat: Create new transaction testing framework TxTest#6537
bthomee merged 72 commits into
developfrom
a1q123456/new-jtx

Conversation

@a1q123456

@a1q123456 a1q123456 commented Mar 12, 2026

Copy link
Copy Markdown
Contributor

High Level Overview of Change

This PR creates a new transaction testing framework TxTest and migrated an existing test suite AccountSet_test.cpp to use gtest.

Context of Change

As part of the modularisation, we want to move transactor tests from xrpld to libxrpl and use gtest

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

@a1q123456
Add code generator
34c49ff 
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
@a1q123456
Updated the template
78d8f89 
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
@a1q123456
Address comments
672f35a 
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
@a1q123456
Remove useless function
474992f 
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
@a1q123456
Restore file
6675801 
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
@a1q123456
Restore file
e4810a6 
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
@a1q123456
Update
3a5937e 
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
@a1q123456
Update gitignore
84b3aab 
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
@a1q123456
Merge branch 'develop' into a1q123456/add-code-generator
fb50ce0
@a1q123456
Merge branch 'develop' into a1q123456/add-code-generator
22d93d2
@a1q123456
Fix formatting
424b930 
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
@a1q123456
Fix levelisation error
a3eaae1 
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
@a1q123456
Add unit tests for STObjectValidation
b5717e0 
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
@a1q123456
Added unit tests and fixed some small issues
423ab87 
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
@a1q123456
Added unit tests and fixed some small issues
665e607 
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
@a1q123456
Merge remote-tracking branch 'origin/develop' into a1q123456/add-code…
37ea600 
…-generator

Signed-off-by: JCW <a1q123456@users.noreply.github.com>

# Conflicts:
#	cmake/XrplCore.cmake
#	cmake/XrplInstall.cmake
@a1q123456
Rename a file
0cb5f70 
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
@a1q123456
Fix levelisation error
d3a1274 
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
@a1q123456
Fix formatting errors
ef42a8f 
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
@a1q123456
Fix line ending issues for windows
199bc0c 
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
@a1q123456
Fix line ending issues for windows
70a85c1 
Added more tests.

Signed-off-by: JCW <a1q123456@users.noreply.github.com>
@a1q123456
Remove test code
8d3ed36 
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
@a1q123456
Merge origin/develop
515bd1a 
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
@a1q123456
Merge branch 'develop' into a1q123456/add-code-generator
368845c
@a1q123456
Make warpps hold shared pointers to align how SLE and STTx are used i…
7f1f540 
…n the code base && Renamed the folder ledger_obejcts to ledger_entries to match the namespace
@a1q123456
Address PR comments
5834f0c 
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
@a1q123456
a1q123456 force-pushed the a1q123456/new-jtx branch 2 times, most recently from 2741d24 to 12ddfb6 Compare March 12, 2026 13:06
xrplf-ai-reviewer[bot]
xrplf-ai-reviewer Bot approved these changes Apr 27, 2026
View reviewed changes

@xrplf-ai-reviewer xrplf-ai-reviewer Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues.

Review by Claude Opus 4.6 · Prompt: V15

xrplf-ai-reviewer[bot]
xrplf-ai-reviewer Bot approved these changes Apr 27, 2026
View reviewed changes

@xrplf-ai-reviewer xrplf-ai-reviewer Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues.

Review by Claude Opus 4.6 · Prompt: V15

xrplf-ai-reviewer[bot]
xrplf-ai-reviewer Bot approved these changes Apr 27, 2026
View reviewed changes

@xrplf-ai-reviewer xrplf-ai-reviewer Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues.

Review by Claude Opus 4.6 · Prompt: V15

xrplf-ai-reviewer[bot]
xrplf-ai-reviewer Bot approved these changes Apr 27, 2026
View reviewed changes

@xrplf-ai-reviewer xrplf-ai-reviewer Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues.

Review by Claude Opus 4.6 · Prompt: V15

xrplf-ai-reviewer[bot]
xrplf-ai-reviewer Bot approved these changes Apr 27, 2026
View reviewed changes

@xrplf-ai-reviewer xrplf-ai-reviewer Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues.

Review by Claude Opus 4.6 · Prompt: V15

xrplf-ai-reviewer[bot]
xrplf-ai-reviewer Bot approved these changes Apr 27, 2026
View reviewed changes

@xrplf-ai-reviewer xrplf-ai-reviewer Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues.

Review by Claude Opus 4.6 · Prompt: V15

shawnxie999
shawnxie999 reviewed Apr 27, 2026
View reviewed changes
Comment thread src/tests/libxrpl/helpers/TxTest.cpp
shawnxie999
shawnxie999 approved these changes Apr 27, 2026
View reviewed changes

@shawnxie999 shawnxie999 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left a minor comment. Also we look to support MPT class in addition to IOUs at some point? since MPT will be new token standard going forward.

@a1q123456
Ensure iou.issue.account is not the current account
ddf3c30 
Co-authored-by: Copilot <copilot@github.com>
@a1q123456 a1q123456 added the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label Apr 27, 2026
xrplf-ai-reviewer[bot]
xrplf-ai-reviewer Bot approved these changes Apr 27, 2026
View reviewed changes

@xrplf-ai-reviewer xrplf-ai-reviewer Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Review by Claude Opus 4.6 · Prompt: V15

@bthomee bthomee changed the title feat: New JTx feat: Create new transaction testing framework TxTest Apr 27, 2026
@bthomee bthomee changed the title feat: Create new transaction testing framework TxTest feat: Create new transaction testing framework TxTest Apr 27, 2026
@bthomee
bthomee enabled auto-merge April 27, 2026 20:43
@bthomee
bthomee added this pull request to the merge queue Apr 27, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 27, 2026
@bthomee
bthomee added this pull request to the merge queue Apr 28, 2026
Merged via the queue into develop with commit 46b997b Apr 28, 2026
3 checks passed
@bthomee
bthomee deleted the a1q123456/new-jtx branch April 28, 2026 14:54
marek-foss-neti pushed a commit to marek-foss-neti/rippled that referenced this pull request May 5, 2026
@a1q123456 @xrplf-ai-reviewer @bthomee
feat: Create new transaction testing framework TxTest (XRPLF#6537)
60fc9da 
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
Co-authored-by: Copilot <copilot@github.com>
@mvadari mvadari added this to the 3.2.0 milestone May 20, 2026
beartec-jpg pushed a commit to beartec-jpg/FalconLedger that referenced this pull request Jun 1, 2026
@a1q123456 @xrplf-ai-reviewer
feat: Create new transaction testing framework TxTest (XRPLF#6537)
1dcffa1 
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
Co-authored-by: xrplf-ai-reviewer[bot] <266832837+xrplf-ai-reviewer[bot]@users.noreply.github.com>
Co-authored-by: Copilot <copilot@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@godexsoft godexsoft godexsoft approved these changes
@shawnxie999 shawnxie999 shawnxie999 approved these changes
@neti-soft-com neti-soft-com neti-soft-com approved these changes
+1 more reviewer
@xrplf-ai-reviewer xrplf-ai-reviewer[bot] xrplf-ai-reviewer[bot] approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required.

Projects

None yet

Milestone

3.2.0

Development

Successfully merging this pull request may close these issues.

7 participants

@a1q123456 @bthomee @godexsoft @shawnxie999 @neti-soft-com @mvadari