Sponsored Content
Skip to content

refactor: Simplify set/get call to use existing variable - #6534

Merged
bthomee merged 2 commits into
XRPLF:developfrom
mvadari:fix-optexp
Mar 13, 2026
Merged

refactor: Simplify set/get call to use existing variable#6534
bthomee merged 2 commits into
XRPLF:developfrom
mvadari:fix-optexp

Conversation

@mvadari

@mvadari mvadari commented Mar 11, 2026

Copy link
Copy Markdown
Contributor

High Level Overview of Change

See title

Context of Change

AI code review

Type of Change

  • Refactor (non-breaking change that only restructures code)

API Impact

N/A

@mvadari
mvadari requested a review from oleks-rip March 11, 2026 21:51
@mvadari mvadari added the Trivial Simple change with minimal effect, or already tested. Only needs one approval. label Mar 11, 2026
@codecov

codecov Bot commented Mar 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.8%. Comparing base (c1d108e) to head (6b86679).
⚠️ Report is 50 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #6534     +/-   ##
=========================================
- Coverage     79.8%   79.8%   -0.0%     
=========================================
  Files          878     878             
  Lines        67887   67887             
  Branches      7551    7571     +20     
=========================================
- Hits         54205   54180     -25     
- Misses       13682   13707     +25     
Files with missing lines Coverage Δ
...pl/tx/transactors/credentials/CredentialCreate.cpp 100.0% <100.0%> (ø)

... and 5 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mvadari mvadari added the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label Mar 12, 2026
@bthomee bthomee changed the title refactor: Simplify get call to use existing variable refactor: Simplify set/get call to use existing variable Mar 13, 2026
@bthomee
bthomee enabled auto-merge (squash) March 13, 2026 13:31
@bthomee
bthomee merged commit 7a3bf16 into XRPLF:develop Mar 13, 2026
1 check passed
@mvadari mvadari added the AI Triage Bugs and fixes that have been triaged via AI initiatives label Mar 24, 2026
@mvadari mvadari added this to the 3.2.0 milestone May 20, 2026
beartec-jpg pushed a commit to beartec-jpg/FalconLedger that referenced this pull request Jun 1, 2026
…#6534)

The `setFieldU32` call is currently used to set the credential's expiry using a `getFieldU32` call to obtain the expiration time. However, that value was already obtained previously and can thus be reused.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI Triage Bugs and fixes that have been triaged via AI initiatives Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. Trivial Simple change with minimal effect, or already tested. Only needs one approval.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants