refactor: Use hasExpired in CancelCheck - #6533
Merged
Merged
Conversation
bthomee
requested review from
a1q123456,
Copilot and
pratikmankawde
and removed request for
bthomee
March 11, 2026 21:22
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors CancelCheck::preclaim to use the shared hasExpired(ReadView, optional<uint32_t>) helper for check expiration logic, aligning this transactor with other expiration checks in the codebase.
Changes:
- Replaced inline expiration comparison logic with
hasExpired(ctx.view, (*sleCheck)[~sfExpiration]). - Removed now-unneeded local
NetClocktype aliases and intermediateoptExpiryvariable.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #6533 +/- ##
=======================================
Coverage 79.8% 79.9%
=======================================
Files 878 878
Lines 67888 67887 -1
Branches 7552 7546 -6
=======================================
+ Hits 54203 54214 +11
+ Misses 13685 13673 -12
... and 6 files with indirect coverage changes 🚀 New features to boost your workflow:
|
a1q123456
approved these changes
Mar 16, 2026
a1q123456
left a comment
a1q123456
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Have checked the logic and can confirm it's identical.
mvadari
added
Ready to merge
bthomee
enabled auto-merge (squash)
March 16, 2026 16:35
godexsoft
added a commit
to godexsoft/rippled
that referenced
this pull request
Mar 16, 2026
Add .clang-tidy with commented out check Fix suggestions Bring back BEAST_EXPECT Address more comments Fix compilation error Fix review suggestions refactor: use `hasExpired` in `CancelCheck` (XRPLF#6533)
mvadari
added
the
AI Triage
beartec-jpg
pushed a commit
to beartec-jpg/FalconLedger
that referenced
this pull request
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Title says it pretty much in its entirety. This simplifies the code a bit and aligns it with other expiry calls.
Worth checking in review as well, but
hasExpiredis identical to the code being replaced, so no amendment is needed here.Context of Change
AI code review
Type of Change
API Impact
N/A