Sponsored Content
Skip to content

fix: Remove unneeded import, fix log - #6532

Merged
bthomee merged 1 commit into
XRPLF:developfrom
mvadari:smol-nits
Mar 11, 2026
Merged

fix: Remove unneeded import, fix log#6532
bthomee merged 1 commit into
XRPLF:developfrom
mvadari:smol-nits

Conversation

@mvadari

@mvadari mvadari commented Mar 11, 2026

Copy link
Copy Markdown
Contributor

High Level Overview of Change

This PR:

  • Removes an unneeded import in DeleteAccount.cpp
  • Fixes a typoed log statement in SetAccount.cpp

That is it.

Context of Change

AI code review

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

API Impact

N/A

@mvadari
mvadari requested a review from bthomee March 11, 2026 19:19
@mvadari mvadari added the Trivial Simple change with minimal effect, or already tested. Only needs one approval. label Mar 11, 2026
@mvadari mvadari added the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label Mar 11, 2026
@bthomee
bthomee enabled auto-merge (squash) March 11, 2026 19:31
@bthomee
bthomee merged commit ce9ccf8 into XRPLF:develop Mar 11, 2026
1 check passed
@codecov

codecov Bot commented Mar 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.8%. Comparing base (c791cae) to head (3cfacd7).
⚠️ Report is 59 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #6532     +/-   ##
=========================================
- Coverage     79.8%   79.8%   -0.0%     
=========================================
  Files          862     862             
  Lines        67883   67883             
  Branches      7551    7554      +3     
=========================================
- Hits         54199   54192      -7     
- Misses       13684   13691      +7     
Files with missing lines Coverage Δ
...c/libxrpl/tx/transactors/account/DeleteAccount.cpp 96.4% <ø> (ø)
src/libxrpl/tx/transactors/account/SetAccount.cpp 98.6% <100.0%> (ø)

... and 5 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mvadari mvadari added the AI Triage Bugs and fixes that have been triaged via AI initiatives label Mar 24, 2026
@mvadari mvadari added this to the 3.2.0 milestone May 20, 2026
beartec-jpg pushed a commit to beartec-jpg/FalconLedger that referenced this pull request Jun 1, 2026
This change:
* Removes an unneeded import in `DeleteAccount.cpp`.
* Fixes a typo in a log statement in `SetAccount.cpp`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI Triage Bugs and fixes that have been triaged via AI initiatives Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. Trivial Simple change with minimal effect, or already tested. Only needs one approval.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants