Sponsored Content
Skip to content

fix: Add missed clang-tidy bugprone-inc-dec-conditions check - #6526

Merged
bthomee merged 2 commits into
XRPLF:developfrom
godexsoft:chore/clang-tidy-checks-inc-dec-conditions2
Mar 11, 2026
Merged

fix: Add missed clang-tidy bugprone-inc-dec-conditions check#6526
bthomee merged 2 commits into
XRPLF:developfrom
godexsoft:chore/clang-tidy-checks-inc-dec-conditions2

Conversation

@godexsoft

Copy link
Copy Markdown
Contributor

High Level Overview of Change

This PR fixes the currently failing clang-tidy check in develop.

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

No impact.

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

@godexsoft
godexsoft requested a review from mathbunnyru March 11, 2026 12:01
@godexsoft godexsoft added the Trivial Simple change with minimal effect, or already tested. Only needs one approval. label Mar 11, 2026
@godexsoft godexsoft added the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label Mar 11, 2026
@bthomee bthomee changed the title fix: A missed clang-tidy bugprone-inc-dec-conditions check fix: Add missed clang-tidy bugprone-inc-dec-conditions check Mar 11, 2026
@bthomee
bthomee enabled auto-merge (squash) March 11, 2026 13:46
@bthomee
bthomee merged commit 7b3724b into XRPLF:develop Mar 11, 2026
1 check passed
@codecov

codecov Bot commented Mar 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.8%. Comparing base (bee2d11) to head (9c562f3).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #6526     +/-   ##
=========================================
- Coverage     79.9%   79.8%   -0.0%     
=========================================
  Files          862     862             
  Lines        67881   67883      +2     
  Branches      7548    7551      +3     
=========================================
- Hits         54204   54200      -4     
- Misses       13677   13683      +6     
Files with missing lines Coverage Δ
src/xrpld/app/ledger/detail/LedgerReplayer.cpp 89.8% <100.0%> (+0.2%) ⬆️

... and 2 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mvadari mvadari added this to the 3.2.0 milestone May 20, 2026
beartec-jpg pushed a commit to beartec-jpg/FalconLedger that referenced this pull request Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. Trivial Simple change with minimal effect, or already tested. Only needs one approval.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants