Sponsored Content
Skip to content

ci: Only upload artifacts in the XRPLF/rippled repository - #6523

Merged
bthomee merged 3 commits into
developfrom
bthomee/repo
Mar 11, 2026
Merged

ci: Only upload artifacts in the XRPLF/rippled repository#6523
bthomee merged 3 commits into
developfrom
bthomee/repo

Conversation

@bthomee

@bthomee bthomee commented Mar 11, 2026

Copy link
Copy Markdown
Collaborator

High Level Overview of Change

This change will only attempt to upload artifacts for CI runs performed in the XRPLF/rippled repository.

Context of Change

When we want to try out something new in a separate repository based on the rippled repository, the CI pipelines will fail when they try to upload the artifacts. We should only attempt to upload artifacts in the rippled repository.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

Copilot AI review requested due to automatic review settings March 11, 2026 08:08

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates CI workflow guards so artifact- and package-upload steps only run when the workflow is executing in the canonical XRPLF/rippled repository, avoiding failures in downstream clones/forks that lack the required credentials or infrastructure.

Changes:

  • Switch multiple workflow if: conditions from github.repository_owner == 'XRPLF' to github.repository == 'XRPLF/rippled'.
  • Restrict Conan remote login/upload and recipe-upload jobs to only execute in XRPLF/rippled.
  • Restrict binary artifact upload and Codecov upload to only execute in XRPLF/rippled.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
.github/workflows/upload-conan-deps.yml Restricts Conan remote login/upload steps to the XRPLF/rippled repo.
.github/workflows/reusable-build-test-config.yml Restricts Linux binary artifact upload and Codecov upload to the XRPLF/rippled repo.
.github/workflows/on-trigger.yml Restricts the develop-branch recipe upload job to the XRPLF/rippled repo.
.github/workflows/on-tag.yml Restricts tag-triggered recipe upload job to the XRPLF/rippled repo.
.github/workflows/on-pr.yml Restricts PR-based recipe upload job to the XRPLF/rippled repo.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

# Only run when committing to a PR that targets a release branch in the
# XRPLF repository.
if: ${{ github.repository_owner == 'XRPLF' && needs.should-run.outputs.go == 'true' && startsWith(github.ref, 'refs/heads/release') }}
if: ${{ github.repository == 'XRPLF/rippled' && needs.should-run.outputs.go == 'true' && startsWith(github.ref, 'refs/heads/release') }}

Copilot AI Mar 11, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In a pull_request workflow, github.ref is typically refs/pull/<n>/merge (not the target branch). This startsWith(github.ref, 'refs/heads/release') check will never be true for PRs targeting release branches, so upload-recipe will be skipped. Use the PR base branch context instead (e.g., github.base_ref / github.event.pull_request.base.ref) and keep merge_group behavior in mind if it should also upload for merge queue runs. Also, the preceding comment says “XRPLF repository” but the condition now targets XRPLF/rippled; updating the comment would keep the intent clear.

Copilot uses AI. Check for mistakes.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be fixed in a separate PR.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #6524.

Comment thread .github/workflows/on-trigger.yml Outdated
Comment thread .github/workflows/on-tag.yml Outdated
@codecov

codecov Bot commented Mar 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.8%. Comparing base (24a5cba) to head (0281278).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #6523     +/-   ##
=========================================
- Coverage     79.8%   79.8%   -0.0%     
=========================================
  Files          862     862             
  Lines        67881   67881             
  Branches      7555    7558      +3     
=========================================
- Hits         54199   54185     -14     
- Misses       13682   13696     +14     

see 5 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bthomee bthomee added the Trivial Simple change with minimal effect, or already tested. Only needs one approval. label Mar 11, 2026
@bthomee
bthomee requested a review from mathbunnyru March 11, 2026 08:28
@bthomee
bthomee merged commit 3baf545 into develop Mar 11, 2026
3 checks passed
@bthomee
bthomee deleted the bthomee/repo branch March 11, 2026 10:48
mathbunnyru pushed a commit that referenced this pull request Apr 2, 2026
This change will only attempt to upload artifacts for CI runs performed in the XRPLF/rippled repository.
ximinez pushed a commit that referenced this pull request Apr 6, 2026
This change will only attempt to upload artifacts for CI runs performed in the XRPLF/rippled repository.
@mvadari mvadari added this to the 3.2.0 milestone May 20, 2026
beartec-jpg pushed a commit to beartec-jpg/FalconLedger that referenced this pull request Jun 1, 2026
This change will only attempt to upload artifacts for CI runs performed in the XRPLF/rippled repository.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Trivial Simple change with minimal effect, or already tested. Only needs one approval.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants