ci: Move Type of Change from PR template to CONTRIBUTING - #6522
Merged
Conversation
bthomee
reviewed
Mar 11, 2026
mathbunnyru
changed the title
mvadari
reviewed
Mar 11, 2026
| - `perf:` - The primary purpose is performance improvements. | ||
| - `chore:` - Other tasks that don't affect the binary, but don't fit any of the other cases. e.g. `git` settings, `clang-tidy`, removing dead code, dropping support for older tooling. | ||
|
|
||
| First letter after the type prefix should be capitalized, and the type prefix should be followed by a colon and a space. e.g. `feat: Add support for Borrowing Protocol`. |
Contributor
There was a problem hiding this comment.
Why are we enforcing this rule? Just trying to understand
Contributor
Author
There was a problem hiding this comment.
It makes the automatic changelog look nice and uniform, for example: https://github.com/XRPLF/clio/releases/tag/2.7.0
bthomee
reviewed
Mar 11, 2026
mathbunnyru
added
Trivial
bthomee
approved these changes
Mar 12, 2026
beartec-jpg
pushed a commit
to beartec-jpg/FalconLedger
that referenced
this pull request
Jun 1, 2026
Now that prefixes in PR titles are being validated as part of CI, the "Type of Change" section in the PR template is no longer needed. The prefixes and descriptions in the `CONTRIBUTING.md` file have been updated to reflect the currently supported list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Since we use validated prefix, this is no longer needed, and is not needed to be checked.
I also adapted the list to the new prefixes, updated descriptions and put them to CONTRIBUTING file.
Context of Change
Type of Change
.gitignore, formatting, dropping support for older tooling)API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)