Sponsored Content
Skip to content

chore: Fix clang-tidy issues from merging unused-local-non-trivial-variable - #6509

Merged
bthomee merged 2 commits into
XRPLF:developfrom
godexsoft:chore/clang-tidy-checks-unused-local-non-trivial-variable2
Mar 9, 2026
Merged

chore: Fix clang-tidy issues from merging unused-local-non-trivial-variable#6509
bthomee merged 2 commits into
XRPLF:developfrom
godexsoft:chore/clang-tidy-checks-unused-local-non-trivial-variable2

Conversation

@godexsoft

Copy link
Copy Markdown
Contributor

High Level Overview of Change

This PR fixes some more issues that were not detected in the original PR (strange) but popped up in develop: https://github.com/XRPLF/rippled/actions/runs/22860818639/job/66313977737

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

No impact.

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

@bthomee bthomee added the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label Mar 9, 2026
@bthomee
bthomee enabled auto-merge (squash) March 9, 2026 16:54
@bthomee
bthomee merged commit 0335076 into XRPLF:develop Mar 9, 2026
1 check passed
@codecov

codecov Bot commented Mar 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.9%. Comparing base (e2290b1) to head (d5ffc9b).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #6509   +/-   ##
=======================================
  Coverage     79.8%   79.9%           
=======================================
  Files          862     862           
  Lines        67876   67873    -3     
  Branches      7556    7543   -13     
=======================================
+ Hits         54185   54204   +19     
+ Misses       13691   13669   -22     
Files with missing lines Coverage Δ
src/libxrpl/ledger/View.cpp 94.5% <ø> (-<0.1%) ⬇️
src/xrpld/app/ledger/detail/InboundLedger.cpp 36.1% <ø> (+0.1%) ⬆️
src/xrpld/core/detail/Config.cpp 77.8% <ø> (-<0.1%) ⬇️

... and 7 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mvadari mvadari added this to the 3.2.0 milestone May 20, 2026
beartec-jpg pushed a commit to beartec-jpg/FalconLedger that referenced this pull request Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants