Sponsored Content
Skip to content

chore: Use check-pr-title from XRPLF/actions - #6506

Merged
bthomee merged 3 commits into
XRPLF:developfrom
mathbunnyru:check_pr_title
Mar 9, 2026
Merged

chore: Use check-pr-title from XRPLF/actions#6506
bthomee merged 3 commits into
XRPLF:developfrom
mathbunnyru:check_pr_title

Conversation

@mathbunnyru

Copy link
Copy Markdown
Contributor

High Level Overview of Change

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

@mathbunnyru mathbunnyru changed the title chore: Use check-pr-title from XRPLF/actions wrong-chore: Use check-pr-title from XRPLF/actions Mar 9, 2026
@mathbunnyru mathbunnyru changed the title wrong-chore: Use check-pr-title from XRPLF/actions chore: use check-pr-title from XRPLF/actions Mar 9, 2026
@mathbunnyru mathbunnyru changed the title chore: use check-pr-title from XRPLF/actions chore: Use check-pr-title from XRPLF/actions Mar 9, 2026
@mathbunnyru
mathbunnyru requested a review from bthomee March 9, 2026 16:03
@mathbunnyru mathbunnyru added the Trivial Simple change with minimal effect, or already tested. Only needs one approval. label Mar 9, 2026

@bthomee bthomee left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be added to the on-pr.yml file? Then it can be used as part of the success/failure ("pass") checks.

@mathbunnyru

Copy link
Copy Markdown
Contributor Author

Shouldn't this be added to the on-pr.yml file? Then it can be used as part of the success/failure ("pass") checks.

It can't be added there, because on-pr is not triggered on edited.
It's crucial for pr-title check (because edited is for title changes), and useless for other workflows.

But, after merge, please add this job to the list of required checks.

@mathbunnyru mathbunnyru added the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label Mar 9, 2026
@bthomee
bthomee merged commit 7e2b137 into XRPLF:develop Mar 9, 2026
1 check passed
@codecov

codecov Bot commented Mar 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.8%. Comparing base (e2290b1) to head (97069d2).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #6506   +/-   ##
=======================================
  Coverage     79.8%   79.8%           
=======================================
  Files          862     862           
  Lines        67876   67876           
  Branches      7556    7551    -5     
=======================================
+ Hits         54185   54196   +11     
+ Misses       13691   13680   -11     

see 5 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mvadari mvadari added this to the 3.2.0 milestone May 20, 2026
beartec-jpg pushed a commit to beartec-jpg/FalconLedger that referenced this pull request Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. Trivial Simple change with minimal effect, or already tested. Only needs one approval.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants