Sponsored Content
Skip to content

chore: Add custom cmake definitions for gersemi - #6491

Merged
bthomee merged 2 commits into
XRPLF:developfrom
mathbunnyru:custom_cmake_funcs
Mar 6, 2026
Merged

chore: Add custom cmake definitions for gersemi#6491
bthomee merged 2 commits into
XRPLF:developfrom
mathbunnyru:custom_cmake_funcs

Conversation

@mathbunnyru

@mathbunnyru mathbunnyru commented Mar 6, 2026

Copy link
Copy Markdown
Contributor

High Level Overview of Change

This adds definitions for our custom functions/macros, and they format nicely too by gersemi.

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

@mathbunnyru mathbunnyru changed the title Custom cmake funcs chore: Add custom cmake definitions for gersemi Mar 6, 2026
@mathbunnyru
mathbunnyru requested a review from bthomee March 6, 2026 12:20
@mathbunnyru mathbunnyru added the Trivial Simple change with minimal effect, or already tested. Only needs one approval. label Mar 6, 2026
@codecov

codecov Bot commented Mar 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.8%. Comparing base (5865bd0) to head (4c36e6c).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #6491   +/-   ##
=======================================
  Coverage     79.8%   79.8%           
=======================================
  Files          861     861           
  Lines        67858   67858           
  Branches      7573    7552   -21     
=======================================
+ Hits         54147   54176   +29     
+ Misses       13711   13682   -29     

see 9 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mathbunnyru mathbunnyru added the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label Mar 6, 2026
@bthomee
bthomee merged commit 7b12c00 into XRPLF:develop Mar 6, 2026
3 checks passed
@mvadari mvadari added this to the 3.2.0 milestone May 20, 2026
beartec-jpg pushed a commit to beartec-jpg/FalconLedger that referenced this pull request Jun 1, 2026
This change adds definitions for our custom functions/macros, so gersemi will nicely format them too.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. Trivial Simple change with minimal effect, or already tested. Only needs one approval.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants