Sponsored Content
Skip to content

style: Use gersemi instead of ancient cmake-format - #6486

Merged
ximinez merged 2 commits into
XRPLF:developfrom
mathbunnyru:gersemi
Mar 6, 2026
Merged

style: Use gersemi instead of ancient cmake-format#6486
ximinez merged 2 commits into
XRPLF:developfrom
mathbunnyru:gersemi

Conversation

@mathbunnyru

@mathbunnyru mathbunnyru commented Mar 5, 2026

Copy link
Copy Markdown
Contributor

cmake-format hasn't been updated in 5 years, and the styling is weird even with heavy customization.
gersemi looks nice, by default, with 0 configuration, and has been updated recently.

In my opinion it also just looks better.

High Level Overview of Change

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

@mathbunnyru
mathbunnyru requested review from bthomee and legleux March 5, 2026 19:27
Comment thread cmake/deps/Boost.cmake
target_link_libraries(xrpl_boost INTERFACE Boost::disable_autolinking)
endif ()

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it already

@mathbunnyru mathbunnyru added the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label Mar 5, 2026
@codecov

codecov Bot commented Mar 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.9%. Comparing base (dde4507) to head (af0ec7d).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #6486   +/-   ##
=======================================
  Coverage     79.8%   79.9%           
=======================================
  Files          861     861           
  Lines        67858   67858           
  Branches      7556    7553    -3     
=======================================
+ Hits         54167   54188   +21     
+ Misses       13691   13670   -21     

see 7 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ximinez
ximinez merged commit af0ec7d into XRPLF:develop Mar 6, 2026
3 checks passed
@mvadari mvadari added this to the 3.2.0 milestone May 20, 2026
beartec-jpg pushed a commit to beartec-jpg/FalconLedger that referenced this pull request Jun 1, 2026
beartec-jpg pushed a commit to beartec-jpg/FalconLedger that referenced this pull request Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants