chore: Use CMake components for install - #6485
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #6485 +/- ##
=======================================
Coverage 79.8% 79.8%
=======================================
Files 862 862
Lines 67881 67881
Branches 7555 7550 -5
=======================================
+ Hits 54188 54198 +10
+ Misses 13693 13683 -10 🚀 New features to boost your workflow:
|
mathbunnyru
reviewed
Mar 5, 2026
legleux
force-pushed
the
legleux/use_components
branch
from
March 6, 2026 20:25
12df8fd to
2e9eda1
Compare
mathbunnyru
requested changes
Mar 6, 2026
mathbunnyru
left a comment
Contributor
There was a problem hiding this comment.
Thanks for merging latest develop, please take a look at comments I left
legleux
force-pushed
the
legleux/use_components
branch
from
March 7, 2026 00:43
2e9eda1 to
1a82819
Compare
legleux
force-pushed
the
legleux/use_components
branch
from
March 7, 2026 03:48
1a82819 to
9c0ae67
Compare
legleux
force-pushed
the
legleux/use_components
branch
from
March 7, 2026 03:57
9c0ae67 to
a034694
Compare
mathbunnyru
requested changes
Mar 8, 2026
mathbunnyru
approved these changes
Mar 9, 2026
legleux
enabled auto-merge (squash)
March 10, 2026 23:10
beartec-jpg
pushed a commit
to beartec-jpg/FalconLedger
that referenced
this pull request
Jun 1, 2026
* chore: Use components for install * rm CMake export targets * reformat
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This PR groups
xrplartifacts in different installation groups based on use.xrpld,validator-keys)libxrpl.a, headers, etcThe CMake target export configuration has been removed also.
Context of Change
Generation of binary packages and Conan packages requires less customization scripts if the installation structure matches the distribution structure.
Removes flaky symlink creation and "works on my machine" hard-coded paths.
runtime_install ├── bin │ ├── validator-keys │ └── xrpld └── etc └── xrpld ├── validators.txt └── xrpld.cfg development_install (depth truncated for clarity) ├── include │ └── xrpl │ ├── basics │ ├── beast │ ├── conditions │ ├── core │ ├── crypto │ ├── json │ ├── ledger │ ├── net │ ├── nodestore │ ├── proto │ ├── protocol │ ├── rdb │ ├── resource │ ├── server │ ├── shamap │ └── tx └── lib ├── libxrpl.a └── libxrpl.libpb.aRemove unconditional installation of 3rd party SDKs
Don't install
antithesis-sdk-cppjust because.Remove
rippled/xrpldsymlink logic from install targetsThis has been fragile and broken things all over the place over the years.
Let this be part of a "to-be-deprecated" binary packaging convenience and let installs from source do what they desire.
Type of Change
.gitignore, formatting, dropping support for older tooling)