fix: Fix docs deployment for pull requests - #6482
Merged
Merged
Conversation
legleux
added
the
Trivial
bthomee
approved these changes
Mar 5, 2026
bthomee
left a comment
bthomee
left a comment
Collaborator
There was a problem hiding this comment.
Let me know if the repository settings need to be updated as well.
beartec-jpg
pushed a commit
to beartec-jpg/FalconLedger
that referenced
this pull request
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Fix so the docs build works in pull requests.
Context of Change
Splits the publish-docs workflow into build and deploy jobs so that the github-pages environment is only associated with the deploy job.
Previously the environment was on the single job, causing GitHub to reject the workflow for pull requests due to environment protection rules, even though deployment was guarded by a step-level condition.
Type of Change