chore: Enable clang-tidy bugprone-unused-return-value check

[godexsoft]

High Level Overview of Change

This PR enables clang-tidy bugprone-unused-return-value check.

There is potentially a way to fix those by defining BOOST_ASIO_NO_DEPRECATED or even rewrite parts to use more modern asio API. But that's a much larger, scary and unrelated to clang-tidy effort. So for now we just nolint these because the code works fine as is.

Context of Change

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Refactor (non-breaking change that only restructures code)
• Performance (increase or change in throughput and/or latency)
• Tests (you added tests for code that already exists, or your new feature included in this PR)
• Documentation update
• Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
• Release

API Impact

No impact.

• Public API: New feature (new methods and/or new fields)
• Public API: Breaking change (in general, breaking changes should only impact the next api_version)
• libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
• Peer protocol change (must be backward compatible or bump the peer protocol version)

[codecov]

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.8%. Comparing base (1738a69) to head (d7e003d).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines	Patch %	Lines
src/xrpld/overlay/detail/ConnectAttempt.cpp	0.0%	1 Missing ⚠️
src/xrpld/overlay/detail/PeerImp.cpp	0.0%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##           develop   #6475     +/-   ##
=========================================
- Coverage     79.8%   79.8%   -0.0%     
=========================================
  Files          878     878             
  Lines        67885   67885             
  Branches      7547    7554      +7     
=========================================
- Hits         54206   54194     -12     
- Misses       13679   13691     +12     

Files with missing lines	Coverage Δ
src/libxrpl/basics/make_SSLContext.cpp	56.3% <ø> (ø)
src/libxrpl/beast/insight/StatsDCollector.cpp	0.0% <ø> (ø)
src/libxrpl/net/RegisterSSLCerts.cpp	100.0% <ø> (ø)
src/xrpld/overlay/detail/ConnectAttempt.cpp	0.0% <0.0%> (ø)
src/xrpld/overlay/detail/PeerImp.cpp	5.9% <0.0%> (ø)

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Copilot]

Pull request overview

Enables the clang-tidy bugprone-unused-return-value check and suppresses newly reported findings in a few Boost.Asio call sites where the return value is intentionally ignored (code relies on the error_code& out-param behavior and/or the operation is best-effort).

Changes:

• Turn on bugprone-unused-return-value in .clang-tidy and configure CheckedReturnTypes.
• Add targeted NOLINT(bugprone-unused-return-value) / NOLINTNEXTLINE(bugprone-unused-return-value) suppressions for Boost.Asio close, shutdown, and SSL context setup calls.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
.clang-tidy	Enables bugprone-unused-return-value and sets CheckedReturnTypes.
src/xrpld/overlay/detail/PeerImp.cpp	Suppresses unused-return-value warning on socket_.close(ec) in peer shutdown path.
src/xrpld/overlay/detail/ConnectAttempt.cpp	Suppresses unused-return-value warning on socket_.close(ec) in connection attempt shutdown.
src/tests/libxrpl/net/HTTPClient.cpp	Suppresses unused-return-value warning on TCP socket shutdown in test server coroutine.
src/test/server/Server_test.cpp	Suppresses unused-return-value warning on TCP socket shutdown in unit tests.
src/libxrpl/net/RegisterSSLCerts.cpp	Suppresses unused-return-value warning on set_default_verify_paths(ec).
src/libxrpl/beast/insight/StatsDCollector.cpp	Suppresses unused-return-value warning on UDP socket shutdown.
src/libxrpl/basics/make_SSLContext.cpp	Suppresses unused-return-value warning on SSL context certificate/private key file loading.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[pratikmankawde]

LGTM