Sponsored Content
Skip to content

chore: Enable clang-tidy bugprone-too-small-loop-variable check - #6473

Merged
bthomee merged 5 commits into
XRPLF:developfrom
godexsoft:chore/clang-tidy-checks-too-small-loop-variable
Mar 10, 2026
Merged

chore: Enable clang-tidy bugprone-too-small-loop-variable check#6473
bthomee merged 5 commits into
XRPLF:developfrom
godexsoft:chore/clang-tidy-checks-too-small-loop-variable

Conversation

@godexsoft

Copy link
Copy Markdown
Contributor

High Level Overview of Change

This PR enables clang-tidy bugprone-too-small-loop-variable check.

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

No impact.

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

@godexsoft godexsoft added the DraftRunCI Normally CI does not run on draft PRs. This opts in. label Mar 4, 2026
@codecov

codecov Bot commented Mar 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.8%. Comparing base (45b8c4d) to head (f3a6aab).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #6473     +/-   ##
=========================================
- Coverage     79.8%   79.8%   -0.0%     
=========================================
  Files          862     862             
  Lines        67875   67875             
  Branches      7551    7549      -2     
=========================================
- Hits         54194   54191      -3     
- Misses       13681   13684      +3     

see 6 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@godexsoft godexsoft added Trivial Simple change with minimal effect, or already tested. Only needs one approval. and removed DraftRunCI Normally CI does not run on draft PRs. This opts in. labels Mar 4, 2026
@godexsoft
godexsoft marked this pull request as ready for review March 4, 2026 16:30
Comment thread src/test/app/AMM_test.cpp
@godexsoft godexsoft added the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label Mar 9, 2026
@bthomee
bthomee enabled auto-merge (squash) March 10, 2026 08:36
@bthomee
bthomee merged commit 92983d8 into XRPLF:develop Mar 10, 2026
1 check passed
@mvadari mvadari added this to the 3.2.0 milestone May 20, 2026
beartec-jpg pushed a commit to beartec-jpg/FalconLedger that referenced this pull request Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. Trivial Simple change with minimal effect, or already tested. Only needs one approval.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants