Sponsored Content
Skip to content

chore: Enable clang-tidy bugprone-pointer-arithmetic-on-polymorphic-object check - #6469

Merged
bthomee merged 5 commits into
XRPLF:developfrom
godexsoft:chore/clang-tidy-checks-pointer-arithmetic-on-polymorphic-object
Mar 9, 2026
Merged

chore: Enable clang-tidy bugprone-pointer-arithmetic-on-polymorphic-object check#6469
bthomee merged 5 commits into
XRPLF:developfrom
godexsoft:chore/clang-tidy-checks-pointer-arithmetic-on-polymorphic-object

Conversation

@godexsoft

@godexsoft godexsoft commented Mar 4, 2026

Copy link
Copy Markdown
Contributor

High Level Overview of Change

This PR enables clang-tidy bugprone-pointer-arithmetic-on-polymorphic-object check.

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

No impact.

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

@godexsoft godexsoft changed the title chore: Enable clang-tidy // NOLINT(bugprone-pointer-arithmetic-on-polymorphic-object) chore: Enable clang-tidy bugprone-pointer-arithmetic-on-polymorphic-object check Mar 4, 2026
@godexsoft godexsoft added the DraftRunCI Normally CI does not run on draft PRs. This opts in. label Mar 4, 2026
@codecov

codecov Bot commented Mar 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.8%. Comparing base (0335076) to head (f13fd8c).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #6469   +/-   ##
=======================================
  Coverage     79.8%   79.8%           
=======================================
  Files          862     862           
  Lines        67873   67875    +2     
  Branches      7550    7550           
=======================================
+ Hits         54193   54195    +2     
  Misses       13680   13680           
Files with missing lines Coverage Δ
src/libxrpl/tx/transactors/bridge/XChainBridge.cpp 91.2% <100.0%> (+<0.1%) ⬆️

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@godexsoft godexsoft removed the DraftRunCI Normally CI does not run on draft PRs. This opts in. label Mar 4, 2026
@godexsoft
godexsoft marked this pull request as ready for review March 4, 2026 15:22
@godexsoft godexsoft added the Trivial Simple change with minimal effect, or already tested. Only needs one approval. label Mar 4, 2026
@godexsoft godexsoft added the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label Mar 9, 2026
@bthomee
bthomee merged commit e284969 into XRPLF:develop Mar 9, 2026
1 check passed
@mvadari mvadari added this to the 3.2.0 milestone May 20, 2026
beartec-jpg pushed a commit to beartec-jpg/FalconLedger that referenced this pull request Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. Trivial Simple change with minimal effect, or already tested. Only needs one approval.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants