chore: Enable clang-tidy bugprone-unused-local-non-trivial-variable check

[godexsoft]

High Level Overview of Change

This PR enables clang-tidy bugprone-unused-local-non-trivial-variable check.

Context of Change

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Refactor (non-breaking change that only restructures code)
• Performance (increase or change in throughput and/or latency)
• Tests (you added tests for code that already exists, or your new feature included in this PR)
• Documentation update
• Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
• Release

API Impact

• Public API: New feature (new methods and/or new fields)
• Public API: Breaking change (in general, breaking changes should only impact the next api_version)
• libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
• Peer protocol change (must be backward compatible or bump the peer protocol version)

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.8%. Comparing base (9e0d350) to head (7697282).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

@@            Coverage Diff            @@
##           develop   #6458     +/-   ##
=========================================
- Coverage     79.8%   79.8%   -0.0%     
=========================================
  Files          861     861             
  Lines        67858   67857      -1     
  Branches      7551    7552      +1     
=========================================
- Hits         54178   54176      -2     
- Misses       13680   13681      +1     

Files with missing lines	Coverage Δ
src/xrpld/app/consensus/RCLConsensus.cpp	59.2% <ø> (-0.1%)	⬇️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Copilot]

Pull request overview

Enables the clang-tidy bugprone-unused-local-non-trivial-variable check and updates a few code/test sites to comply by removing unused non-trivial locals and avoiding repeated temporary creation.

Changes:

• Enable bugprone-unused-local-non-trivial-variable in .clang-tidy.
• Remove unused local variables (e.g., std::stringstream, std::string) flagged by the new check.
• Minor test cleanup to avoid repeating asString() calls.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
src/xrpld/app/consensus/RCLConsensus.cpp	Removes an unused std::stringstream local.
src/test/rpc/Peers_test.cpp	Avoids repeated asString() call by storing tag in a local.
src/test/rpc/LedgerEntry_test.cpp	Removes unused locals and simplifies a test block scope.
src/test/app/Manifest_test.cpp	Removes an unused std::string local.
.clang-tidy	Enables bugprone-unused-local-non-trivial-variable.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.