Sponsored Content
Skip to content

chore: Enable clang-tidy bugprone-reserved-identifier check - #6456

Merged
bthomee merged 9 commits into
XRPLF:developfrom
godexsoft:chore/clang-tidy-checks-reserved-identifier
Mar 10, 2026
Merged

chore: Enable clang-tidy bugprone-reserved-identifier check#6456
bthomee merged 9 commits into
XRPLF:developfrom
godexsoft:chore/clang-tidy-checks-reserved-identifier

Conversation

@godexsoft

Copy link
Copy Markdown
Contributor

High Level Overview of Change

This PR enables clang-tidy bugprone-reserved-identifier check.

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

@godexsoft godexsoft added the DraftRunCI Normally CI does not run on draft PRs. This opts in. label Mar 3, 2026
@codecov

codecov Bot commented Mar 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.8%. Comparing base (92983d8) to head (30d7767).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #6456     +/-   ##
=========================================
- Coverage     79.9%   79.8%   -0.0%     
=========================================
  Files          862     862             
  Lines        67875   67875             
  Branches      7546    7552      +6     
=========================================
- Hits         54203   54188     -15     
- Misses       13672   13687     +15     
Files with missing lines Coverage Δ
src/libxrpl/tx/invariants/InvariantCheck.cpp 95.8% <100.0%> (ø)

... and 8 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@godexsoft godexsoft removed the DraftRunCI Normally CI does not run on draft PRs. This opts in. label Mar 3, 2026
@godexsoft
godexsoft marked this pull request as ready for review March 3, 2026 14:29
Copilot AI review requested due to automatic review settings March 3, 2026 14:29

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Enables the clang-tidy bugprone-reserved-identifier check and updates code to avoid triggering it, improving static analysis coverage and preventing use of C++ reserved identifier patterns in the codebase.

Changes:

  • Enabled bugprone-reserved-identifier in .clang-tidy.
  • Renamed a structured-binding component in AccountRootsDeletedClean::finalize to avoid a reserved identifier (__).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/libxrpl/tx/invariants/InvariantCheck.cpp Avoids a reserved identifier in a structured binding used during invariant checks.
.clang-tidy Turns on the bugprone-reserved-identifier clang-tidy check.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/libxrpl/tx/invariants/InvariantCheck.cpp Outdated
@bthomee
bthomee requested a review from pratikmankawde March 4, 2026 21:39
Comment thread src/libxrpl/tx/invariants/InvariantCheck.cpp Outdated

@pratikmankawde pratikmankawde left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Left a minor suggestion.

@godexsoft
godexsoft requested a review from bthomee March 9, 2026 17:46
@godexsoft godexsoft added the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label Mar 9, 2026
@bthomee
bthomee merged commit 1a7d67c into XRPLF:develop Mar 10, 2026
3 checks passed
@mvadari mvadari added this to the 3.2.0 milestone May 20, 2026
beartec-jpg pushed a commit to beartec-jpg/FalconLedger that referenced this pull request Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants