chore: Enable clang-tidy bugprone-reserved-identifier check - #6456
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #6456 +/- ##
=========================================
- Coverage 79.9% 79.8% -0.0%
=========================================
Files 862 862
Lines 67875 67875
Branches 7546 7552 +6
=========================================
- Hits 54203 54188 -15
- Misses 13672 13687 +15
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Enables the clang-tidy bugprone-reserved-identifier check and updates code to avoid triggering it, improving static analysis coverage and preventing use of C++ reserved identifier patterns in the codebase.
Changes:
- Enabled
bugprone-reserved-identifierin.clang-tidy. - Renamed a structured-binding component in
AccountRootsDeletedClean::finalizeto avoid a reserved identifier (__).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/libxrpl/tx/invariants/InvariantCheck.cpp |
Avoids a reserved identifier in a structured binding used during invariant checks. |
.clang-tidy |
Turns on the bugprone-reserved-identifier clang-tidy check. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pratikmankawde
left a comment
There was a problem hiding this comment.
Looks good. Left a minor suggestion.
High Level Overview of Change
This PR enables clang-tidy
bugprone-reserved-identifiercheck.Context of Change
Type of Change
.gitignore, formatting, dropping support for older tooling)API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)