chore: Make nix hook optional - #6431
Conversation
There was a problem hiding this comment.
Pull request overview
This PR makes the nix pre-commit hook optional for local development environments while keeping it enforced in GitHub Actions CI. This allows developers without nix installed to run pre-commit hooks successfully, while still ensuring nix files are properly formatted in CI.
Changes:
- Modified the nix-fmt pre-commit hook to conditionally execute based on nix availability or GitHub Actions environment
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ximinez
left a comment
There was a problem hiding this comment.
Works on my end.
What do you think about running pre-commit with --verbose in the action?
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #6431 +/- ##
=========================================
- Coverage 79.8% 79.8% -0.0%
=========================================
Files 848 848
Lines 67757 67757
Branches 7558 7559 +1
=========================================
- Hits 54074 54063 -11
- Misses 13683 13694 +11 🚀 New features to boost your workflow:
|
This change makes the `nix` pre-commit hook optional in development environments, and enforced only inside Github Actions.
High Level Overview of Change
This PR makes nix pre-commit hook optional in development environment and enforced only inside Github Actions.
Context of Change
Type of Change
.gitignore, formatting, dropping support for older tooling)API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)