Sponsored Content
Skip to content

chore: Make nix hook optional - #6431

Merged
bthomee merged 3 commits into
XRPLF:developfrom
kuznetsss:Optional_nix_hook
Feb 27, 2026
Merged

chore: Make nix hook optional#6431
bthomee merged 3 commits into
XRPLF:developfrom
kuznetsss:Optional_nix_hook

Conversation

@kuznetsss

Copy link
Copy Markdown
Contributor

High Level Overview of Change

This PR makes nix pre-commit hook optional in development environment and enforced only inside Github Actions.

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

Copilot AI review requested due to automatic review settings February 26, 2026 12:19

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR makes the nix pre-commit hook optional for local development environments while keeping it enforced in GitHub Actions CI. This allows developers without nix installed to run pre-commit hooks successfully, while still ensuring nix files are properly formatted in CI.

Changes:

  • Modified the nix-fmt pre-commit hook to conditionally execute based on nix availability or GitHub Actions environment

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ximinez ximinez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on my end.

What do you think about running pre-commit with --verbose in the action?

@kuznetsss

Copy link
Copy Markdown
Contributor Author

@ximinez, good idea! I've added --verbose in pre-commit call and updated action hash.

@kuznetsss kuznetsss added the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label Feb 26, 2026
Copilot AI review requested due to automatic review settings February 27, 2026 15:14

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov

codecov Bot commented Feb 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.8%. Comparing base (404f35d) to head (449dca4).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #6431     +/-   ##
=========================================
- Coverage     79.8%   79.8%   -0.0%     
=========================================
  Files          848     848             
  Lines        67757   67757             
  Branches      7558    7559      +1     
=========================================
- Hits         54074   54063     -11     
- Misses       13683   13694     +11     

see 5 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bthomee
bthomee merged commit b58c681 into XRPLF:develop Feb 27, 2026
3 checks passed
@mvadari mvadari added this to the 3.2.0 milestone May 20, 2026
beartec-jpg pushed a commit to beartec-jpg/FalconLedger that referenced this pull request Jun 1, 2026
This change makes the `nix` pre-commit hook optional in development environments, and enforced only inside Github Actions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants