chore: Enable clang-tidy checks without issues - #6414
Conversation
There was a problem hiding this comment.
Pull request overview
This PR enables 78 additional clang-tidy checks that are already passing in the codebase. By uncommenting previously disabled checks across bugprone, cppcoreguidelines, hicpp, misc, readability, modernize, and performance categories, the codebase gains additional static analysis coverage without requiring any code changes. The CheckOptions section is also activated with one option enabled.
Changes:
- Enabled 78 clang-tidy checks that were previously commented out but are now passing
- Reorganized commented checks that still have issues into clearer sections
- Uncommented CheckOptions section and enabled
bugprone-unsafe-functions.ReportMoreUnsafeFunctions: true
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #6414 +/- ##
=========================================
- Coverage 79.8% 79.8% -0.0%
=========================================
Files 848 848
Lines 67757 67757
Branches 7559 7552 -7
=========================================
- Hits 54075 54074 -1
- Misses 13682 13683 +1 see 7 files with indirect coverage changes 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com>
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com>
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
godexsoft
added
the
Ready to merge
Updated instructions for running clang-tidy to refer to BUILD.md for build steps.
|
@bthomee @kuznetsss @mathbunnyru I have updated the doc to simply require to build the project before running clang-tidy. This was suggested by @bthomee. |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This change enables all clang-tidy checks that are already passing. It also modifies the clang-tidy CI job, so it runs against all files if .clang-tidy changed.
High Level Overview of Change
This PR enables all clang-tidy checks that are already passing. Also modifying the clang-tidy CI job so it runs against all files if
.clang-tidychanged.Context of Change
Type of Change
.gitignore, formatting, dropping support for older tooling)API Impact
No impact.