Sponsored Content
Skip to content

chore: Update cleanup-workspace to delete old .conan2 dir on macOS - #6412

Merged
ximinez merged 3 commits into
XRPLF:developfrom
mathbunnyru:delete_old_conan_macos
Feb 25, 2026
Merged

chore: Update cleanup-workspace to delete old .conan2 dir on macOS#6412
ximinez merged 3 commits into
XRPLF:developfrom
mathbunnyru:delete_old_conan_macos

Conversation

@mathbunnyru

@mathbunnyru mathbunnyru commented Feb 23, 2026

Copy link
Copy Markdown
Contributor

High Level Overview of Change

Uses updated cleanup-workspace due to XRPLF/actions#70

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

Copilot AI review requested due to automatic review settings February 23, 2026 17:28

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the GitHub Actions workflows to use a newer pinned revision of XRPLF/actions/cleanup-workspace, aligning CI cleanup behavior with the updated action (notably for macOS workspace cleanup).

Changes:

  • Bump XRPLF/actions/cleanup-workspace pin from cf0433a… to c7d9ce5… in the Conan dependency upload workflow.
  • Bump XRPLF/actions/cleanup-workspace pin from cf0433a… to c7d9ce5… in the reusable build/test workflow.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/upload-conan-deps.yml Updates the cleanup-workspace action pin used before checkout on macOS/Windows runners.
.github/workflows/reusable-build-test-config.yml Updates the cleanup-workspace action pin in the reusable build/test steps for macOS/Windows runners.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@godexsoft godexsoft left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:rage2:

@codecov

codecov Bot commented Feb 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.8%. Comparing base (bdd106d) to head (f70cbb7).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #6412   +/-   ##
=======================================
  Coverage     79.8%   79.8%           
=======================================
  Files          848     848           
  Lines        67763   67763           
  Branches      7556    7554    -2     
=======================================
+ Hits         54069   54077    +8     
+ Misses       13694   13686    -8     

see 7 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mathbunnyru mathbunnyru added Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. Trivial Simple change with minimal effect, or already tested. Only needs one approval. labels Feb 24, 2026
@ximinez
ximinez enabled auto-merge (squash) February 25, 2026 00:47
Copilot AI review requested due to automatic review settings February 25, 2026 00:47

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ximinez
ximinez merged commit 65e63eb into XRPLF:develop Feb 25, 2026
1 check passed
@mvadari mvadari added this to the 3.2.0 milestone May 20, 2026
beartec-jpg pushed a commit to beartec-jpg/FalconLedger that referenced this pull request Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. Trivial Simple change with minimal effect, or already tested. Only needs one approval.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants