Sponsored Content
Skip to content

ci: Build docs in PRs and in private repos - #6400

Merged
ximinez merged 2 commits into
XRPLF:developfrom
mathbunnyru:fix_docs_build
Feb 20, 2026
Merged

ci: Build docs in PRs and in private repos#6400
ximinez merged 2 commits into
XRPLF:developfrom
mathbunnyru:fix_docs_build

Conversation

@mathbunnyru

@mathbunnyru mathbunnyru commented Feb 20, 2026

Copy link
Copy Markdown
Contributor

High Level Overview of Change

This:

  • builds docs in PRs correctly (including PRs created from forks)
  • makes it work in private repos, where ubunu-latest is a runner with only 2 CPUs

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

Copilot AI review requested due to automatic review settings February 20, 2026 14:38

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the documentation publishing workflow so it selects a smaller parallelism reduction when running in private repositories, accommodating GitHub-hosted runner CPU limits to avoid over-subtracting cores during the docs build.

Changes:

  • Set NPROC_SUBTRACT dynamically based on whether the repository is private (1) or not (2).
  • Add inline comments and a reference link explaining the private-repo runner CPU constraint.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mathbunnyru mathbunnyru changed the title ci: Build docs in private repos ci: Build docs in PRs and in private repos Feb 20, 2026
@mathbunnyru mathbunnyru added Trivial Simple change with minimal effect, or already tested. Only needs one approval. Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. labels Feb 20, 2026

@godexsoft godexsoft left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:rage1:

@ximinez
ximinez merged commit cb54ade into XRPLF:develop Feb 20, 2026
1 check passed
@mvadari mvadari added this to the 3.2.0 milestone May 20, 2026
beartec-jpg pushed a commit to beartec-jpg/FalconLedger that referenced this pull request Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. Trivial Simple change with minimal effect, or already tested. Only needs one approval.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants