trivial: Fix tautological assert - #6393
Conversation
ximinez
added
Bug
Trivial
There was a problem hiding this comment.
Pull request overview
Fixes a tautological assertion in Keylet::check() so it correctly rejects invalid STLedgerEntry types (ltANY / ltCHILD), aligning with LedgerEntryType documentation that these special values are not valid on-ledger object types.
Changes:
- Replace
||with&&in theXRPL_ASSERTcondition insideKeylet::check().
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…fix-keylet-assert * commit '25cca465538a56cce501477f9e5e2c1c7ea2d84c': chore: Set clang-format width to 100 in config file (6387) chore: Set cmake-format width to 100 (6386) ci: Add clang tidy workflow to ci (6369)
…et-assert * upstream/develop: chore: Apply clang-format width 100 (6387)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #6393 +/- ##
=========================================
- Coverage 79.8% 79.8% -0.0%
=========================================
Files 846 846
Lines 67746 67746
Branches 7561 7560 -1
=========================================
- Hits 54059 54049 -10
- Misses 13687 13697 +10
... and 6 files with indirect coverage changes 🚀 New features to boost your workflow:
|
ximinez
added
the
Ready to merge
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
High Level Overview of Change
sle.getType() != ltANY || sle.getType() != ltCHILDcan't be false. Change to&&.Context of Change
Looks like a simple typo introduced in af5f28c#diff-952cdb0e645311ca00fe512132b41c9b4d7dd160e38ce8f4c1df0992cfa7aa5b which has managed to go unnoticed.
Type of Change
Before / After
This change should have no noticeable effect, unless there are existing bugs in
Keylethandling. Since it's an assert, it won't have any effect on published packages.