chore: Set clang-format width to 100 - #6387
Conversation
There was a problem hiding this comment.
Copilot wasn't able to review this pull request. There are 300 or more changed files, try reducing the number of files in this pull request and requesting a review from Copilot again.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
c7fb0be to
b4bdc1d
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #6387 +/- ##
=========================================
- Coverage 80.0% 79.8% -0.2%
=========================================
Files 846 846
Lines 65700 67746 +2046
Branches 7256 7561 +305
=========================================
+ Hits 52536 54059 +1523
- Misses 13164 13687 +523
🚀 New features to boost your workflow:
|
ximinez
left a comment
There was a problem hiding this comment.
Could you split this PR into two commits? The first would only change .clang-format, and the second would do the actual formatting. (Include "(#6387)" in both of the commit messages.)
Historically, but inconsistently, we have done it this way to make it easier for others to merge. Basically, a developer would merge up to and including the .clang-format commit only, then format themselves, commit, and merge in the rest. There may still be conflicts, but they're usually greatly reduced. This also removes the need to use -x ours, which can have unpredictable results in some cases.
b4bdc1d to
db890ae
Compare
There was a problem hiding this comment.
Copilot wasn't able to review this pull request. There are 300 or more changed files, try reducing the number of files in this pull request and requesting a review from Copilot again.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
db890ae to
2c1fad1
Compare
Done 👍 |
High Level Overview of Change
Context of Change
Type of Change
.gitignore, formatting, dropping support for older tooling)API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)