Sponsored Content
Skip to content

chore: Set clang-format width to 100 - #6387

Merged
ximinez merged 2 commits into
XRPLF:developfrom
mathbunnyru:clang_format_100
Feb 20, 2026
Merged

chore: Set clang-format width to 100#6387
ximinez merged 2 commits into
XRPLF:developfrom
mathbunnyru:clang_format_100

Conversation

@mathbunnyru

Copy link
Copy Markdown
Contributor

High Level Overview of Change

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

Copilot AI review requested due to automatic review settings February 19, 2026 13:07

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request. There are 300 or more changed files, try reducing the number of files in this pull request and requesting a review from Copilot again.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mathbunnyru mathbunnyru added Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. Trivial Simple change with minimal effect, or already tested. Only needs one approval. labels Feb 19, 2026
@codecov

codecov Bot commented Feb 19, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 87.79577% with 294 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.8%. Comparing base (469ce9f) to head (2c1fad1).
⚠️ Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
src/libxrpl/beast/insight/StatsDCollector.cpp 0.0% 28 Missing ⚠️
src/libxrpl/protocol/XChainAttestations.cpp 38.2% 21 Missing ⚠️
src/libxrpl/shamap/SHAMapSync.cpp 45.5% 18 Missing ⚠️
src/libxrpl/net/HTTPClient.cpp 61.5% 15 Missing ⚠️
include/xrpl/server/detail/BaseHTTPPeer.h 63.9% 13 Missing ⚠️
src/libxrpl/json/json_reader.cpp 50.0% 12 Missing ⚠️
src/libxrpl/nodestore/backend/RocksDBFactory.cpp 26.7% 11 Missing ⚠️
src/libxrpl/shamap/SHAMapDelta.cpp 26.7% 11 Missing ⚠️
include/xrpl/net/HTTPClientSSLContext.h 0.0% 9 Missing ⚠️
include/xrpl/protocol/STValidation.h 33.3% 8 Missing ⚠️
... and 51 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #6387     +/-   ##
=========================================
- Coverage     80.0%   79.8%   -0.2%     
=========================================
  Files          846     846             
  Lines        65700   67746   +2046     
  Branches      7256    7561    +305     
=========================================
+ Hits         52536   54059   +1523     
- Misses       13164   13687    +523     
Files with missing lines Coverage Δ
include/xrpl/basics/DecayingSample.h 88.2% <100.0%> (+0.4%) ⬆️
include/xrpl/basics/Expected.h 100.0% <100.0%> (ø)
include/xrpl/basics/IntrusivePointer.h 91.7% <ø> (ø)
include/xrpl/basics/IntrusiveRefCounts.h 92.7% <100.0%> (+0.2%) ⬆️
include/xrpl/basics/LocalValue.h 100.0% <100.0%> (ø)
include/xrpl/basics/Log.h 71.4% <ø> (ø)
include/xrpl/basics/Number.h 98.7% <100.0%> (+<0.1%) ⬆️
include/xrpl/basics/SharedWeakCachePointer.ipp 75.5% <ø> (ø)
include/xrpl/basics/Slice.h 96.8% <100.0%> (+0.1%) ⬆️
include/xrpl/basics/StringUtilities.h 100.0% <ø> (ø)
... and 263 more

... and 218 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ximinez ximinez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you split this PR into two commits? The first would only change .clang-format, and the second would do the actual formatting. (Include "(#6387)" in both of the commit messages.)

Historically, but inconsistently, we have done it this way to make it easier for others to merge. Basically, a developer would merge up to and including the .clang-format commit only, then format themselves, commit, and merge in the rest. There may still be conflicts, but they're usually greatly reduced. This also removes the need to use -x ours, which can have unpredictable results in some cases.

@ximinez ximinez mentioned this pull request Feb 19, 2026
13 tasks
Copilot AI review requested due to automatic review settings February 19, 2026 23:27

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request. There are 300 or more changed files, try reducing the number of files in this pull request and requesting a review from Copilot again.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mathbunnyru

Copy link
Copy Markdown
Contributor Author

Could you split this PR into two commits? The first would only change .clang-format, and the second would do the actual formatting. (Include "(#6387)" in both of the commit messages.)

Historically, but inconsistently, we have done it this way to make it easier for others to merge. Basically, a developer would merge up to and including the .clang-format commit only, then format themselves, commit, and merge in the rest. There may still be conflicts, but they're usually greatly reduced. This also removes the need to use -x ours, which can have unpredictable results in some cases.

Done 👍

@ximinez ximinez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ximinez
ximinez merged commit 2c1fad1 into XRPLF:develop Feb 20, 2026
1 check passed
@mvadari mvadari added this to the 3.2.0 milestone May 20, 2026
beartec-jpg pushed a commit to beartec-jpg/FalconLedger that referenced this pull request Jun 1, 2026
beartec-jpg pushed a commit to beartec-jpg/FalconLedger that referenced this pull request Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. Trivial Simple change with minimal effect, or already tested. Only needs one approval.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants