refactor: Rename system name from 'ripple' to 'xrpld' - #6347
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the core “system name” constant used across xrpld for default config/data directory selection (XDG + /etc/opt//var/opt) and for RPC metadata/user-agent strings, aligning with the ongoing rename effort in XLS-0095.
Changes:
- Update
systemName()from"ripple"to"xrpld".
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
godexsoft
left a comment
There was a problem hiding this comment.
Not an issue for Clio 👍
May be an issue for someone else but i very much doubt.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6347 +/- ##
=========================================
Coverage ? 79.8%
=========================================
Files ? 878
Lines ? 67894
Branches ? 7555
=========================================
Hits ? 54201
Misses ? 13693
Partials ? 0
🚀 New features to boost your workflow:
|
legleux
left a comment
There was a problem hiding this comment.
Just the Copilot suggestion so we don't get xrpldd in certain places.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Per [XLS-0095](https://xls.xrpl.org/xls/XLS-0095-rename-rippled-to-xrpld.html), we are taking steps to rename ripple(d) to xrpl(d). This change modifies the system name from `rippled` to `xrpld`. The system name is used in limited places: * When no explicit config file is passed via the `--config` flag, then the system name is used to construct the path where the config file and database may be stored, via the `$XDG_CONFIG_HOME` and `$XDG_DATA_HOME` directories, respectively. * It is used in the metadata and user-agent as part of RPC calls. * It is newly used in the full version string.
High Level Overview of Change
This change modifies the system name from
rippledtoxrpld.Context of Change
Per XLS-0095, we are taking steps to rename ripple(d) to xrpl(d).
This change renames the system name, which is used in limited places:
--configflag, then the system name is used to construct the path where the config file and database may be stored, via the$XDG_CONFIG_HOMEand$XDG_DATA_HOMEdirectories, respectively.Type of Change
.gitignore, formatting, dropping support for older tooling)