Sponsored Content
Skip to content

ci: Remove @xrplf/rpc-reviewers - #6337

Merged
bthomee merged 3 commits into
XRPLF:developfrom
mathbunnyru:remove_rpc_reviewers
Feb 6, 2026
Merged

ci: Remove @xrplf/rpc-reviewers#6337
bthomee merged 3 commits into
XRPLF:developfrom
mathbunnyru:remove_rpc_reviewers

Conversation

@mathbunnyru

Copy link
Copy Markdown
Contributor

High Level Overview of Change

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

Copilot AI review requested due to automatic review settings February 6, 2026 16:28

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates repository review ownership rules by removing the @xrplf/rpc-reviewers team from CODEOWNERS, effectively dropping required-reviewer enforcement for RPC-related paths.

Changes:

  • Removed @xrplf/rpc-reviewers ownership rules for RPC/protocol directories in .github/CODEOWNERS.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/CODEOWNERS Outdated

@bthomee bthomee left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we just remove the entire file?

@mathbunnyru

Copy link
Copy Markdown
Contributor Author

Should we just remove the entire file?

I think let's keep it - I might want to add myself for the github/tooling related changes in the future, for example, so it might be useful

@mathbunnyru

Copy link
Copy Markdown
Contributor Author

Oh, GitHub tells it's incorrect right now (and was incorrect before my change), so let's indeed remove it

Copilot AI review requested due to automatic review settings February 6, 2026 16:33

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@bthomee
bthomee merged commit 2305bc9 into XRPLF:develop Feb 6, 2026
1 check passed
@mvadari mvadari added this to the 3.2.0 milestone May 20, 2026
beartec-jpg pushed a commit to beartec-jpg/FalconLedger that referenced this pull request Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants