Sponsored Content
Skip to content

Threads renaming follow up - #6336

Merged
bthomee merged 3 commits into
developfrom
vntb/thread-names-followup
Feb 6, 2026
Merged

Threads renaming follow up#6336
bthomee merged 3 commits into
developfrom
vntb/thread-names-followup

Conversation

@vlntb

@vlntb vlntb commented Feb 6, 2026

Copy link
Copy Markdown
Contributor

High Level Overview of Change

This update builds on the thread-renaming PR (#6212).
It clarifies thread names to reduce ambiguity in performance monitoring tools.
No functional changes.

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

@vlntb vlntb added the Trivial Simple change with minimal effect, or already tested. Only needs one approval. label Feb 6, 2026
@vlntb
vlntb marked this pull request as ready for review February 6, 2026 12:09
@codecov

codecov Bot commented Feb 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.9%. Comparing base (bf4674f) to head (c6ad348).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #6336     +/-   ##
=========================================
- Coverage     79.9%   79.9%   -0.0%     
=========================================
  Files          840     840             
  Lines        65483   65483             
  Branches      7249    7253      +4     
=========================================
- Hits         52318   52313      -5     
- Misses       13165   13170      +5     
Files with missing lines Coverage Δ
src/xrpld/app/main/Main.cpp 77.9% <100.0%> (ø)

... and 4 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vlntb
vlntb requested a review from lmaisons February 6, 2026 15:54

@lmaisons lmaisons left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As requested.

@bthomee
bthomee merged commit db2734c into develop Feb 6, 2026
3 checks passed
@bthomee
bthomee deleted the vntb/thread-names-followup branch February 6, 2026 21:33
@mvadari mvadari added this to the 3.2.0 milestone May 20, 2026
beartec-jpg pushed a commit to beartec-jpg/FalconLedger that referenced this pull request Jun 1, 2026
This change builds on the thread-renaming PR (XRPLF#6212), by renaming the main thread name to reduce ambiguity in performance monitoring tools.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Trivial Simple change with minimal effect, or already tested. Only needs one approval.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants