feat: Add Formats and Flags to server_definitions - #6321
Conversation
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 29 out of 29 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ximinez
left a comment
There was a problem hiding this comment.
All of my concerns have been addressed, though Copilot identified a couple of things.
I haven't done a deep review, so I'm just going to dismiss this approval. There are plenty of other approvals to proceed with.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
## High Level Overview of Change <!-- Please include a summary/list of the changes. If too broad, please consider splitting into multiple PRs. If a relevant Asana task, please link it here. --> Next rippled release will introduce new fields to `server_definitions` (already merged to `develop`): - `TRANSACTION_FORMATS`: Describes the fields and their optionality for each transaction type, including common fields shared across all transactions. - `LEDGER_ENTRY_FORMATS`: Describes the fields and their optionality for each ledger entry type, including common fields shared across all ledger entries. - `TRANSACTION_FLAGS`: Maps transaction type names to their supported flags and flag values. - `LEDGER_ENTRY_FLAGS`: Maps ledger entry type names to their flags and flag values. - `ACCOUNT_SET_FLAGS`: Maps AccountSet flag names (asf flags) to their numeric values. See [feat: Add Formats and Flags to server_definitions](XRPLF/rippled#6321) This will allow our CI tests to pass. ### Type of Change <!-- Please check relevant options, delete irrelevant ones. --> - [x] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Refactor (non-breaking change that only restructures code) - [ ] Tests (You added tests for code that already exists, or your new feature included in this PR) - [ ] Documentation Updates - [ ] Release ### Did you update HISTORY.md? - [ ] Yes - [ ] No, this change does not impact library users ## Test Plan <!-- Please describe the tests that you ran to verify your changes and provide instructions so that others can reproduce. --> All CI tests pass.
|
This is a useful change, but the supplied definitions are incomplete. For a code generator to use this data and to be able to decode the whole ledger, the following inner object definitions need to be added (INNER_OBJECT_FORMATS would be my suggestion): |
This change implements XRPLF/XRPL-Standards#418: "System XLS: Add Formats and Flags to server_definitions".
High Level Overview of Change
Closes #5151
Attempts to implement XRPLF/XRPL-Standards#418
This is a combination of #5702 (bulk of functionality) and #5616 (tests).
If merged:
server_definitions#5702tfBatchMasknot matching the previous constant is fixed and covered by an extra test inBatch_test.cpp.initializer_listwhere applicable.Context of Change
Type of Change
.gitignore, formatting, dropping support for older tooling)API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)